Re: [committed 0/2] CRIS: Fix compilation warnings that recent gcc treats as errors
Hans-Peter Nilsson <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
> Date: Wed, 6 Dec 2023 20:52:48 +0100 > From: Torbjorn SVENSSON <[email protected]> (Sorry for the late reply: the newlib mailer appears to have directed your mail only to the newlib without even a CC to me, so your reply got into my newlib folder, unfortunately not visited daily.) > Hi Hans-Peter, > > On 2023-12-06 18:50, Hans-Peter Nilsson wrote: > > Caveat: a patch-set adding a _getentropy stub > > from August (IIRC) causes lots of FAILs; some of those are worked > > around in gcc to get better coverage. > > What problems are there with the _getentropy stubs that I've submitted? I hope to get into details later, as indicated by the "film at 11". The problem is fairly visible with a standard test-run for cris-elf (with simulator and baseboard cris-sim): all libstdc++ tests fail with a linker warning, as its configure tests detect a presence of _getentropy but its reference trigs the stub warning (the .gnu.warning thing). I *think* it's also visible for a build with arm-eabi+arm-sim which made me wonder how you configured and tested (you may have stated, I haven't looked). Adding a patch to "prune" the stub-warning in libstdc++ prune.exp only exposes runtime errors when _getentropy is actually called. Those errors are not present when _getentropy is not detected (and not used). Looks like I managed to actually state the gist of the problem. Missing are details such as (todo) proposed best actions, besides reverting that patch, to better handle the problem *you* say. That's also all I can say for now. Feel very free to wait until I come back to this: I can't focus on this issue right now; just thought I'd reply with what state I have at the top of my head, since you asked. Sorry! brgds, H-P