Re: [PATCH v1 1/1] configure: correct tooldir install path

Hello Neal,

On Fri, 15 Dec 2023 09:55:29 +0000
Neal Frager <[email protected]> wrote:

> This patch is required to fix how the newlib headers are installed
> when using a sysroot install directory.
> 
> The cross compiler expects headers to be in
> .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
> by default newlib installed the headers into
> .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h
> 
> ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
> ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed.
> 
> Signed-off-by: Neal Frager <[email protected]>
> Co-developed-by: Chris Wardman <[email protected]>
> ---
>  configure | 7 +++++++
>  1 file changed, 7 insertions(+)

The configure script is generated from configure.ac, so you should not
patch configure but configure.ac.

> +  --with-install-sysroot  use sysroot install directory
>    --with-debug-prefix-map='A=B C=D ...'
>                            map A to B, C to D ... in debug information
>    --with-build-config='NAME NAME2...'
> @@ -7057,7 +7059,12 @@ esac
>  
>  # Some systems (e.g., one of the i386-aix systems the gas testers are
>  # using) don't handle "\$" correctly, so don't use it here.
> +# Check whether --with-install-sysroot was given.
> +if test "${with_install_sysroot+set}" = set; then :

--with/--without options are usually not used for boolean things,
instead --enable/--disable option are used for boolean things.

However here, I think that what would make sense is a --with-tooldir
option. When not passed, the value is
'${exec_prefix}'/${target_noncanonical}, and when passed, the value is
the one passed in the option:

 ./configure ... --with-tooldir=/blabla

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com