Re: [PATCH 1/2] libgloss: merge pru into top-level Makefile

Mike Frysinger <[email protected]> Tue, 2 Jan 2024 08:15:40 -0500

Newsgroups	gmane.comp.lib.newlib
Message-ID	<ZZQMfK2sizctJwNx@vapier>

On 02 Jan 2024 10:24, Dimitar Dimitrov wrote:
> --- a/libgloss/pru/Makefile.in
> +++ /dev/null
> @@ -1,145 +0,0 @@
> -# SPDX-License-Identifier: BSD-2-Clause-FreeBSD
> -#
> -# Copyright 2018-2019 Dimitar Dimitrov <[email protected]>
> -# All rights reserved.
> -#
> -# Redistribution and use in source and binary forms, with or without
> -# modification, are permitted provided that the following conditions
> -# are met:
> -# 1. Redistributions of source code must retain the above copyright
> -#    notice, this list of conditions and the following disclaimer.
> -# 2. Redistributions in binary form must reproduce the above copyright
> -#    notice, this list of conditions and the following disclaimer in the
> -#    documentation and/or other materials provided with the distribution.
> -#
> -# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> -# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> -# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> -# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> -# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> -# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> -# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

please retain the license in the new file, but use ## as the comment marker

> --- /dev/null
> +++ b/libgloss/pru/Makefile.inc
> @@ -0,0 +1,19 @@
> +multilibtool_DATA += \
> +	%D%/crt0.o \
> +	%D%/crt0-minrt.o

add the .S files to libobjs_a_SOURCES so automake generates compile rules

otherwise lgtm, thanks !
-mike

signature.asc (application/pgp-signature, 833 B)