RE: [PATCH v3 1/1] configure.ac: configurable tooldir install path

"Frager, Neal" <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <CH2PR12MB500456A16BAEEC32E9190C4BF0682@CH2PR12MB5004.namprd12.prod.outlook.com>
Hi Mike,

Thank you for your feedback.

> +  [case x"$withval" in

> use AS_CASE

Ok.

> +	x/*) ;;
> +	*)
> +	with_tooldir=
> +	AC_MSG_WARN([argument to --with-tooldir must be an absolute path])

> shouldn't this be AC_MSG_ERROR ?  otherwise you're leaving it unset below.
> -mike

Yes, good point.  If the user does not use an absolute
path, this should trigger an error and not just a warning.

I will make these changes in v4.

Best regards,
Neal Frager
AMD
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.