Re: Problem with recent change to getlocalename_l
Jeff Law <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 2/4/24 12:34, Dimitar Dimitrov wrote: > On Thu, Feb 01, 2024 at 08:44:32PM +0100, Corinna Vinschen wrote: >> On Feb 1 20:11, Corinna Vinschen wrote: >>> No, wait. >>> >>> On Feb 1 20:00, Corinna Vinschen wrote: >>>> Given that this new functionality needs a 32 byte buffer, and given that >>>> _REENT_SMALL targets are... well... small, I made the new buffer >>>> optional via `#ifdef _MB_CAPABLE' in struct _misc_reent, which only used >>>> by _REENT_SMALL targets. >>>> >>>> Apparently I missed to take the _REENT_CHECK_MISC expression into account. >>>> AFAICS the culprit is the _REENT_INIT_MISC macro now. >>>> >>>> Can you please check if this change fixes the problem? >>> >>> Try this one instead, please: >> >> Sorry, I suddenly realized that I screwed up the name of the new member >> as well. Sigh. >> >> Please try this one, it's also much simpler: [ ... ] >> > > Hi, > > This fixes the build for pru-unknown-elf, and there are no regressions > when running the GCC and newlib testsuites. Yea, that worked for me as well. All the usual crosses built and passed with the exception of rl78, but I don't think that's a newlib problem, it's more likely a compiler issue. Thanks for the testing Corinna's patch too! jeff