Re: [PATCH] Improve execl* functions
"Richard Earnshaw (lists)" <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 31/01/2025 09:53, Federico Terraneo wrote: > On 29/01/25 12:26, Corinna Vinschen wrote: >> Your patch looks good. At first I thought it's missing the ARG_MAX >> check now, but yeah, in fact that should be tested in execve. >> >> Can you please add the rational for this change to the commit message? >> Code comments like R. Diez suggested, would be helpful as well. >> >> Also, given this adds a compile time option, it would be helpful to >> add a matching option to configure.ac and add it to the README file. >> > > Hi, > I tried adding the compile-time option and re-running autoreconf, but I'm hitting an issue. Despite using GNU Autoconf 2.69 and GNU Automake 1.15.1 as stated in the newlib/HOWTO file, running autoreconf in the newlib directory *before* making any changes to configure.ac generates tons of spurious changes to Makefile.in, see attached patch 0002. > Any idea what I could be doing wrong, I'm on a Debian 12. > > In any case, patch 0001 and 0003 look ok, maybe it's possible to just skip patch 0002? Even though I'd be curious to know what's the issue with autoreconf, maybe some of you encountered it already? > > Best regards, > Federico Terraneo You need to use the vanilla autoconf obtainable from the FSF. Debian's version contains changes that generate the extra verbage that you are seeing. R.