Re: [PATCH] newlib: riscv: Fix build
Eric Salem <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
Hi Kito, On 3/25/25 8:39 PM, Kito Cheng wrote: > Just one more comment, don't put xlenint.h in > newlib/libc/machine/riscv/sys, please move that into > newlib/libc/machine/riscv > The difference between the two is that the former will be installed > into the toolchain, but the latter one won't. > > Otherwise LGTM, also verified on my side :) I'm trying to move the file to that directory, but now the problem I'm facing is sys/string.h in riscv can no longer find the file. Newlib copies the header files to the targ-include directory when building, but only those that are in the machine and sys directories. So when I go to build, it can't find xlenint.h anymore. Any suggestions? Perhaps I'm doing something wrong, but looking at the file layout of other ports, this seems intentional by Newlib, where the libc/machine/<port> directories contain C and assembly files, and all header files go in subdirectories. Eric