Re: [PATCH] newlib: riscv: Fix build

On 3/29/25 5:19 PM, Eric Salem wrote:
> Hi Jeff and Kito,
> 
> On 3/27/25 9:58 AM, Eric Salem wrote:
>> I don't think either of these are supposed to be in the sys directory.
>> However, Christian pointed out:
>>
>> https://sourceware.org/pipermail/libc-alpha/2017-June/081918.html
>>
>> mentions __libc_detect_null() shouldn't be present in a public header. So
>> what I'm going to do is move both sys/string.h and sys/xlenint.h one
>> directory above, update the includes for the various C and assembly files,
>> and send a v2 patch.
>>
>> Jeff, if you don't mind, could you test the patch once it's ready? Just
>> want to ensure it doesn't break any of your builds.
>>
>> Thanks,
>>
>> Eric
> 
> I made the aforementioned changes. I moved both xlenint.h and string.h
> (also renamed the latter to avoid any confusion) to one directory above.
> Now the __libc_* functions defined in that file are no longer being included
> in a public header.
> 
> Could you please test your build systems again with the patch below? If it
> works, I'll send this one as v2.
Worked fine in my builder once I moved the older version out of the way ;-)

jeff