Re: [PING] [PATCH v2] A series of updates related to MIPS

Jovan Dmitrovic <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
Hello Jeff,
thank you for your time. I have forgotten to address those comments you 
made,
I will try to do so now.

> 1. You are deleting crt0.S but crt0.o is referenced in various mips .ld
> files and specified in Makefie.in.  Can you clarify?
crt0.S was moved to hal/ directory. Makefile.in has been changed to 
reflect this.
> 2. You are adding platform-specific checks to generic libnosys and libgloss
> fstat files.  Please clarify why this is being done since you have a
> mips-specific fstat file.

You are correct, I'm not sure about the reasoning behind changing the 
generic fstat, I will fix this in v3.

> 3. abiflags.S doesn't have a license header

This has slipped my attention, it will be added in v3.

> 4. there appears to be examples directories added to mips and to top level
> libgloss in this patch.  Plus, there is a Makefile without generation.

Those test examples aren't supposed to end up here, so I've removed those.

Regards,
Jovan


On 29. 4. 25. 17:13, Jeff Johnston wrote:
> Sorry for the delay, will do.  Please respond to any review questions 
> that are asked.  A while ago, a large patch for mips was posted and
> I asked a few follow-up questions regarding files that were being 
> deleted with no reply.
>
> -- Jeff J.
>
> On Tue, Apr 29, 2025 at 9:43 AM Jovan Dmitrovic 
> <[email protected]> wrote:
>
>     Hello everyone,
>
>
>     I am pinging the community to take a look at a series of patches I
>     sent
>     out about a month ago:
>
>
>     https://sourceware.org/pipermail/newlib/2025/021629.html
>
>
>     Thanks,
>
>     Jovan
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.