Re: [PATCH 0/2] fix undefined reference to `__ssputws_r'

On Jul 20 15:17, Joern Wolfgang Rennecke wrote:
> On Jul 15 10:53 2024, Torbjorn SVENSSON wrote:
> > Hi again,
> >
> > I do not have time to dig into this right now, but these are the test
> cases
> > that start to fail after applying the 2 patches suggested by Hau Hsu:
> >
> > FAIL: 27_io/objects/wchar_t/12048-1.cc  -std=gnu++17 execution test
> > FAIL: 27_io/objects/wchar_t/12048-2.cc  -std=gnu++17 execution test
> > FAIL: 27_io/objects/wchar_t/12048-3.cc  -std=gnu++17 execution test
> > FAIL: 27_io/objects/wchar_t/12048-4.cc  -std=gnu++17 execution test
> > FAIL: 27_io/objects/wchar_t/2.cc  -std=gnu++17 output pattern test
> > FAIL: 27_io/objects/wchar_t/9662.cc  -std=gnu++17 execution test
> > FAIL: ext/stdio_sync_filebuf/wchar_t/1.cc  -std=gnu++17 execution test
> > FAIL: ext/stdio_sync_filebuf/wchar_t/12948-1.cc  -std=gnu++17 execution
> test
> > FAIL: ext/stdio_sync_filebuf/wchar_t/12948-2.cc  -std=gnu++17 execution
> test
> > FAIL: ext/stdio_sync_filebuf/wchar_t/12948-3.cc  -std=gnu++17 execution
> test
> > FAIL: ext/stdio_sync_filebuf/wchar_t/12948-4.cc  -std=gnu++17 execution
> test
> 
> That is a completely irrelevant observation.  A lot of testcases got
> disrupted by the removal of wide character functions, causing link errors,
> or the tests being skipped in the first place when some capability test
> failed.  So any pre-existing execution failures would get masked.
> Re-enabling wide character support makes the execution tests run again,
> so the old execution failures come back.
> 
> We need to decide first if --enable-newlib-nano-formatted-io should or
> should not remove support for wide character handling.
> Then we can look at individual test failures.

Didn't we already remove wchar support at least partially with commit
3b97a5ec67a5 ("libc/stdio: Remove wchar_t functions from
NEWLIB_NANO_FORMATTED_IO")?

So I guess applying https://sourceware.org/pipermail/newlib/2024/021162.html
or something along these lines should be in order.

A new patch or a resend of the patch from 2024 would be most helpful.


Thanks,
Corinna