Re: [EXTERNAL] Re: [PATCH v2] newlib: skip build of AArch64 80bit and 128bit long double functions when sizeof(double) == sizeof(long double)
Corinna Vinschen <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On Jul 21 11:47, Radek Barton via Newlib wrote: > Hello. > > > So, if I'm not completely off-track, you should just define _LDBL_EQ_DBL > > for the aarch64-pc-cygwin target. > > The `_LDBL_EQ_DBL` macro is correctly set by the `configure` even > without changes from my patch. The merit of patch is to skip build of > source codes in `newlib-cygwin/newlib/libm/ld` folder based on the > presence of that macro because it seems that those implementations are > relevant only to the cases where `sizeof(double) != sizeof(long > double)`. Alternatively, I can add checks to `_LDBL_EQ_DBL` macro to > every single file in that folder but that would effectively have the > same effect for the majority of the implementations, as far as I > understand it. No, sorry, I didn't quite get that, apparently. This sounds like a good idea to me. If the files are unused anyway, why build them at all? Craig, since you seem to have a better grasp of the math part in newlib, what do you think? Thanks, Corinna