Re: [PATCH] amdgcn, libm: fix infinite loop

On 08/08/2025 09:14, Thomas Schwinge wrote:
> Hi Andrew!
> 
> On 2025-08-07T13:09:41+0000, Andrew Stubbs <[email protected]> wrote:
>> The end condition on this loop, unlike all the other similar loops, is
>> "i >= 0", which is a problem because "i <<= 1" can go negative and then zero if
>> you continue shifting, and so back to true, again.  This isn't a problem for
>> the loop in the scalar implementation, but it means we need to mask the shift
>> in the vector implementation.
>>
>> This fixes GCC PR#121392.
> 
> Thanks, I confirm this fixes the issue.
> 
> I suggest you 'git push', or I can do it for you if you don't have access
> to newlib Git -- or, I'll be happy to sponsor you to get access, as
> maintainer of the GCN parts in newlib.
> (<https://sourceware.org/cgi-bin/pdw/ps_form.cgi> has the instructions
> for the latter.)

I might be able to push (I can pull via ssh), but I'm not aware of 
having any authority to do so, in this project.

I normally post my patches and one of the maintainers approves and 
applies it.

I'm happy to take that task off their hands if they're happy for me to 
do so, but it's quite rare so I've never pushed for it.

Andrew