Re: [PATCH v2] libc/include/regex.h: Add include of <sys/_types.h> for off_t

Corinna Vinschen <[email protected]> Sat, 7 Feb 2026 10:46:48 +0100
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
On Feb  5 15:15, Joel Sherrill wrote:
> The winsup/ version of regex.h already had this include. Without
> it, including <regex.h> by itself would not compile.
> ---
>  newlib/libc/include/regex.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/newlib/libc/include/regex.h b/newlib/libc/include/regex.h
> index 4da1a374e..0b1c633d0 100644
> --- a/newlib/libc/include/regex.h
> +++ b/newlib/libc/include/regex.h
> @@ -38,9 +38,10 @@
>  #define	_REGEX_H_
>  
>  #include <sys/cdefs.h>
> +#include <sys/_types.h>
>  
>  /* types */
> -typedef off_t regoff_t;
> +typedef _off_t regoff_t;
>  
>  typedef struct {
>  	int re_magic;
> -- 
> 2.47.3

LGTM, please push.


Thanks,
Corinna