Re: [PATCH v0 0/2] Add C23 stdbit.h functions

On Mar 17 18:04, Joel Sherrill wrote:
> On Tue, Mar 17, 2026 at 12:35 PM Corinna Vinschen <[email protected]>
> > The problem with stdbit/Makefile.inc is that you used %D instead of %D%.
> > This breaks the generated Makefile.
> >
> 
> Thanks. and Grrrr.. one character mistakes can be so hard to spot. :(
> 
> >
> > With that fixed, your code still doesn't build (with gcc 13.4.0,
> > cross-building for Cygwin), because the compiler complains about missing
> > definitions for UINT_WIDTH, ULLONG_WIDTH, etc.  Maybe you should use
> > __LONG_WIDTH__ etc.?
> >
> 
> That code is unmodified from FreeBSD.  Once I get this far, I can address
> that.

Yes, please.

> Right now, after autoreconf, I see this error:
> 
> I see this pattern with git diff which looks wrong. Lots of lines in
> Makefile.in
> where the libm_ part disappeared after "common/"
> 
> -libm/common/libm_a-sf_fpclassify.$(OBJEXT):  \
> -       libm/common/$(am__dirstamp) \
> +libm/common/a-sf_fpclassify.$(OBJEXT): libm/common/$(am__dirstamp) \
> 
> And missing the libc_ part after "argz"
> 
> -@ELIX_LEVEL_1_FALSE@   libc/argz/libc_a-envz_strip.$(OBJEXT)
> +@ELIX_LEVEL_1_FALSE@am__objects_1 = libc/argz/a-argz_add.$(OBJEXT) \
> 
> I do not see any modified files that would do this.
> 
> I have run autoreconf with Rocky 9 autotools and locally built unmodified
> versions.
> 
> autoconf (GNU Autoconf) 2.69
> automake (GNU automake) 1.16.5

I think that's a bug in automake 1.16.5.  Doesn't occur with 1.15.1.

> Sorry to be a problem. I just do not seem to be able to regenerate a
> working Makefile.in
> 
> Help appreciated.

Btw., you should probbaly make sure these functions are only built
in ELIX_LEVEL > 3, see libc/search/Makefile.inc line 28ff.


Corinna