Re: [PATCH v0 0/2] Add C23 stdbit.h functions
Corinna Vinschen <[email protected]> Tue, 7 Apr 2026 17:57:18 +0200
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On Apr 3 17:08, Brian Inglis wrote: > On 2026-04-03 11:14, Joel Sherrill wrote: > > Sorry for the delay. I got back to Corrina's comment: > > > > > No, they are not. Target was Cygwin with its own limits.h, but even in > > > newlib's limits.h, these WIDTH macros are not defined. Incidentally, > > > they are not defined anywhere in the newlib-cygwin repo. If this works > > > for you, you're probably overloading the newlib headers with rtems > > > headers. > > > > RTEMS does indeed have its own limits.h. And it must be aligned with C23. > > > > And Cygwin has its own limits.h which has not been updated to have any of > > the new C23 constants. Four show up in compiler error messages building > > the stdbit code. > > > > https://en.cppreference.com/w/c/header/limits.html > > <https://en.cppreference.com/w/c/header/limits.html> > > > > The stdbit.h addition needs a limits.h with the C23 constants. > > > > Can those be added to the Cygwin limits.h? Then we can proceed with > > the stdbit.h addition. > > For fastest response, please submit a patch with subject like: > > [PATCH] Cygwin: winsup/cygwin/include/limits.h: Add C23 ..._WIDTH definitions > > similar to your RTEMS changes, using normal feature test macros as > appropriate, with git format-patch & git send-email to: > > Cygwin core component patch submission and discussion > <[email protected]> Either that (patches are always welcome), or just use the compiler-provided constants. Thanks, Corinna