Re: [PATCH] libgloss: moxie: Remove unnecessary print() declaration
Jeff Johnston <[email protected]> Fri, 29 May 2026 15:28:30 -0400
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAOox84uNVE+xGJBdnL1qtEJyqc0ts-sca+FqfPkCgqh6YU0qOg@mail.gmail.com> |
--0000000000004b21d10652f9da37 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Patch merged. Thanks. -- Jeff J. On Fri, May 29, 2026 at 12:47=E2=80=AFAM Chris Packham <judge.packham@gmail= .com> wrote: > libgloss/glue.h has a declaration of print() so there's no need for > putnum.c to have one (which is incorrect and triggers a compilation > warning/error). > > Signed-off-by: Chris Packham <[email protected]> > --- > libgloss/moxie/putnum.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libgloss/moxie/putnum.c b/libgloss/moxie/putnum.c > index 9af5b4d4c..0f7e89453 100644 > --- a/libgloss/moxie/putnum.c > +++ b/libgloss/moxie/putnum.c > @@ -14,8 +14,6 @@ > */ > #include "glue.h" > > -void print (char *); > - > /* > * putnum -- print a 32 bit number in hex > */ > -- > 2.54.0 > > --0000000000004b21d10652f9da37 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,= sans-serif">Patch merged.=C2=A0 Thanks.</div><div class=3D"gmail_default" s= tyle=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_defau= lt" style=3D"font-family:verdana,sans-serif">-- Jeff J.</div></div><br><div= class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmai= l_attr">On Fri, May 29, 2026 at 12:47=E2=80=AFAM Chris Packham <<a href= =3D"mailto:[email protected]">[email protected]</a>> wrote:<= br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left:1px solid rgb(204,204,204);padding-left:1ex">libgloss/glue.h = has a declaration of print() so there's no need for<br> putnum.c to have one (which is incorrect and triggers a compilation<br> warning/error).<br> <br> Signed-off-by: Chris Packham <<a href=3D"mailto:[email protected]"= target=3D"_blank">[email protected]</a>><br> ---<br> =C2=A0libgloss/moxie/putnum.c | 2 --<br> =C2=A01 file changed, 2 deletions(-)<br> <br> diff --git a/libgloss/moxie/putnum.c b/libgloss/moxie/putnum.c<br> index 9af5b4d4c..0f7e89453 100644<br> --- a/libgloss/moxie/putnum.c<br> +++ b/libgloss/moxie/putnum.c<br> @@ -14,8 +14,6 @@<br> =C2=A0 */<br> =C2=A0#include "glue.h"<br> <br> -void print (char *);<br> -<br> =C2=A0/*<br> =C2=A0 * putnum -- print a 32 bit number in hex<br> =C2=A0 */<br> -- <br> 2.54.0<br> <br> </blockquote></div> --0000000000004b21d10652f9da37--