Re: [PATCH] H8: Minor cleanup in newlib/libc/include/sys/config.h.
Jeff Johnston <[email protected]> Thu, 16 Jul 2026 14:41:48 -0400
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAOox84sijNhWWV6bpfszDyG_beUH+dgGCXf6V_oYEt7v8J+BcQ@mail.gmail.com> |
--000000000000a792620656becb34 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes. Thanks. Patch applied. -- Jeff J. On Wed, Jul 15, 2026 at 7:23=E2=80=AFPM Jan Dubiec <[email protected]> wrote: > On 15.07.2026 01:57, Jeff Johnston wrote: > > Hi Jan, > > > > Even though the H8300 flag isn't used within newlib, it is possible use= r > > code could be referring to it since it is made available > > IMO, it's unlikely, since the compiler already provides the __H8300H__, > __H8300S__, and __H8300SX__ macros. But it's not a big deal. > > > via the header file. If the first definition is wrong, that one can be > > removed, but in the 2nd case, it appears to be correct. > Do you mean something like in the attached patch? > > /J.D. > > --000000000000a792620656becb34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,= sans-serif">Yes.=C2=A0 Thanks.=C2=A0 Patch applied.</div><div class=3D"gmai= l_default" style=3D"font-family:verdana,sans-serif"><br></div><div class=3D= "gmail_default" style=3D"font-family:verdana,sans-serif">-- Jeff J.</div></= div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" c= lass=3D"gmail_attr">On Wed, Jul 15, 2026 at 7:23=E2=80=AFPM Jan Dubiec <= <a href=3D"mailto:[email protected]">[email protected]</a>> wrote:<br></div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol= id rgb(204,204,204);padding-left:1ex">On 15.07.2026 01:57, Jeff Johnston wr= ote:<br> > Hi Jan,<br> > <br> > Even though the H8300 flag isn't used within newlib, it is possibl= e user <br> > code could be referring to it since it is made available<br> <br> IMO, it's unlikely, since the compiler already provides the __H8300H__,= <br> __H8300S__, and __H8300SX__ macros. But it's not a big deal.<br> <br> > via the header file.=C2=A0 If the first definition is wrong, that one = can be <br> > removed, but in the 2nd case, it appears to be correct.<br> Do you mean something like in the attached patch?<br> <br> /J.D.<br> <br> </blockquote></div> --000000000000a792620656becb34--