Re: [PATCH] libgloss/arm: report semihosted directories correctly

Torbjorn SVENSSON <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>

On 2026-08-18 10:33, Andreas Schwab wrote:
> On Aug 14 2026, Torbjörn SVENSSON wrote:
> 
>> +      st->st_mode |= S_IFCHR;
> 
> That doesn't make sense. S_IFMT is a multi-value bitfield, not a
> colletion of single bits.
> 

I know that, but what do you want me to do instead?
The bitgroup is always cleared at this stage, but I can change it to

st->st_mode = (st->st_mode & ~S_IFMT) | S_IFCHR;

if that makes more sense (obviously the same for all the other assignments
in the file).

Let me know what you think.

Kind regards,
Torbjörn
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.