Re: [PATCH] PPC lll_mutex_unlock_force write barrier
Steve Munroe <[email protected]>
| Newsgroups | gmane.comp.lib.phil |
|---|---|
| Message-ID | <OFE34FBAD8.C4A48BFF-ON86256D8F.0078621F-86256D8F.0078FF59@us.ibm.com> |
Alexander Terekhov writes: > Sort of. First off, unless I'm just missing and/or misunderstanding > something, you've put it in the wrong place. Also, a write barrier > isn't enough here. mutex.unlock also needs a read barrier. Actually I was refering to lll_mutex_unlock_force which stuffs a 0 into the lock word then calls lll_futex_wake. This is different from lll_mutex_unlock, which uses atomic_exchange_rel, which includes all the required synchronization.