Re: EDGE_FULL_BACKGROUND

seasoned_geek:

   The attachment is difficult to apply since is diffing each file individually instead of a patch for the whole change.

> Only spot I was a bit uncertain of was this
> 
> int farRight = 500; // just a big number because we could be 2+ monitors wide
> if ((ll->widthLine != 0) && (ll->widthLine != LineLayout::wrapWidthInfinite)) {
> farRight = ll->widthLine;
> }

   It's all too complex. There appears to be some local problem with the order of left and right on your platform. There's also some unnecessary casting/truncation. It can just use the right side of the requested drawing rectangle and rely on FillRectangleAligned so there isn't a fuzzy partial pixel edge.

PRectangle rcSegment = rcLine;
rcSegment.left = vsDraw.theEdge.column * vsDraw.spaceWidth;
surface->FillRectangleAligned(rcSegment, Fill(vsDraw.theEdge.colour));

Neil

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/scintilla-interest/6CAACBA1-E600-4FC7-81B1-164B10383161%40me.com.