Re: EDGE_FULL_BACKGROUND

On 8/28/2024 5:56 PM, 'Neil Hodgson' via scintilla-interest wrote:
> seasoned_geek:
>
>     The attachment is difficult to apply since is diffing each file individually instead of a patch for the whole change.
Fine. I will roll my changes into CsScintilla and it will fork even 
further from Scintilla.
>     It's all too complex. There appears to be some local problem with the order of left and right on your platform. There's also some unnecessary casting/truncation. It can just use the right side of the requested drawing rectangle and rely on FillRectangleAligned so there isn't a fuzzy partial pixel edge.
>
> PRectangle rcSegment = rcLine;
> rcSegment.left = vsDraw.theEdge.column * vsDraw.spaceWidth;
> surface->FillRectangleAligned(rcSegment, Fill(vsDraw.theEdge.colour));

Well, what you suggest was my first attempt and it definitely didn't 
work. There was also a dirth of comments in the code for the necessary 
functions.

Thanks for looking at it.

-- 
Roland Hughes, President
Logikal Solutions
(630)-205-1593  (cell)
https://theminimumyouneedtoknow.com
https://infiniteexposure.net
https://johnsmith-book.com

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/scintilla-interest/e3d43ff3-ea0d-4720-9adc-4d62aeaef1b3%40logikalsolutions.com.