Re: [PATCH] Marker symbol draw on sublines

Mitchell <[email protected]> Wed, 4 Jun 2025 10:44:07 -0400
Newsgroups gmane.comp.lib.scintilla.devel
Message-ID <[email protected]>
Hi Neil,

> On Jun 4, 2025, at 2:05 AM, Neil <[email protected]> wrote:
> 
> Mitchell:
> 
> I chose to use marker symbols instead of marker numbers because (1) it easily supports the existing SC_MARK_BAR and (2) enabling it for individual marker numbers seems tedious. If you disagree, I can resubmit with support for marker numbers instead.
> 
> I'm a bit uncertain for now.
> 
> It does seem more coherent to me for this to be an attribute of a marker number as that allows using a marker both for just head-lines or for both head-lines and body-lines.
> 
> Further extensions might want to follow more of the FoldPart technique used for MarkerSymbol::Bar with 4 bit flags to determine if the marker is drawn for head, body, tail, and headWithTail cases.
> 
> A simpler addition would be to have a continuing (or flowing?) variant of SC_MARK_FULLRECT: SC_MARK_FULLRECT_SUBLINES. There's likely only a small set of other marker symbols that are good candidates for this because they join up: SC_MARK_BACKGROUND and SC_MARK_LEFTRECT.

I am okay with defining a few new subline-enabled markers as you suggest.

With my proposed solution, I was also thinking of handling cases where clients define pixmap markers like error or warning icons that they might want to show on all wrapped lines, but I don’t personally have a use-case for that.

Cheers,
Mitchell

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/scintilla-interest/93EB164B-D1A9-4955-9D22-3E98B0DD6B66%40foicica.com.