Re: How to Patch Official SDL

In github, you can generate diff and patch files, which is what you'll want
to share.  I think the easiest way to to create a branch, then a pull
request, but that is assuming you are working from SDL's repo, and also
that you're using mercurial instead of git.

If you've just been committing to master on your github page, the github
flow I described is going to be painful.  You might be able to find tools
that create .diff or .patch files by comparing two directories, so you
could do a checkout of SDL's mercurial and your git.  Doing a quick google
search got me a few results, and http://stackoverflow.com/a/2463534/661764
looks promising.

Ultimately, I can guarantee no one is going to manually look through your
repo and attempt to identify differences, it's up to you to be able to
provide a patch or diff file.

Your bug report looks fine, and attaching either a diff or patch will make
it much easier for people to see what changes you have made, and be able to
apply those changes locally so they can test for bugs.  Also, have you ran
the SDL tests?  Make sure you run everything in test and visualtest (looks
like http://hg.libsdl.org/SDL/file/42768c568a50/test/testrendertarget.c has
some contact with SDL_RenderReadPixels) to ensure your changes don't
accidentally make other tests fail.

On Tue, Aug 9, 2016 at 9:57 AM, ancientcc <[email protected]> wrote:

> I had created BUG:3406, https://bugzilla.libsdl.org/show_bug.cgi?id=3406
>
>
>
> If there are serval files, it will be difficult to describe.
>
> _______________________________________________
> SDL mailing list
> [email protected]
> http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org
>
>

_______________________________________________
SDL mailing list
[email protected]
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org