Re: How to Patch Official SDL
Alex Barry <[email protected]>
| Newsgroups | gmane.comp.lib.sdl |
|---|---|
| Message-ID | <CAJSO58OZN9O9aRSp80jgp76Z6O+wWryo3kOsRM2DDe7AJX37VA@mail.gmail.com> |
Even so, make sure it passes that test. Unit tests are designed by the original developer to test for known outcomes. The point isn't about whether it works, it's about whether it does the expected thing. If you can't easily give a diff or patch, I guarantee that your bug will be rejected. I've already provided a link that describes creating a .diff file that would be appropriate to attach to the bug. A diff file will capture changes among multiple files, so I'm not sure what your objection is. On Wed, Aug 10, 2016 at 11:03 AM, ancientcc <[email protected]> wrote: > Thank you so much detailed explanation. > > > > Using testrendertarget.c, I did not test the commited patch about > SDL_RenderReadPixels. But I had released serval app calling > SDL_RenderReadPixels, for example, https://itunes.apple.com/us/ > app/zhi-ma-shui-mian/id1068347573. > > > > At present, what I most want is to patch BLE to the official SDL. But for > this module, in addition to modify existing file, but also add to at least > 7 files. By means of commiting bug to https://bugzilla.libsdl.org, it is > estimated that this requirement is difficult to describe. > > > > Recently, I will write an app that auxiliary BLE hardware development. I > want to consider how to patch after completion of this app. > > > > _______________________________________________ > SDL mailing list > [email protected] > http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org > > _______________________________________________ SDL mailing list [email protected] http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org