SDL12: bug in SDL_dx5video.c

"emu1233" <[email protected]>
Newsgroups gmane.comp.lib.sdl
Message-ID <[email protected]>
Noted a bug with a possible patch below based on the fact that the error refers to "SDL surface memory", so the intent of the line must have been to check for a swsurface. The alternative is that the line was meant to disable that block of code, but I would think if(0) would have been used. Thank you for any help.


Code:
--- SDL-1.2-ORIG//src/video/windx5/SDL_dx5video.c
+++ SDL-1.2//src/video/windx5/SDL_dx5video.c
@@ -1784,7 +1784,7 @@ static int DX5_AllocDDSurface(_THIS, SDL
 	}
 	IDirectDrawSurface3_Unlock(dd_surface3, NULL);
 
-	if ( (flag & SDL_HWSURFACE) == SDL_SWSURFACE ) {
+	if ( (flag & SDL_SWSURFACE) == SDL_SWSURFACE ) {
 		if ( ddsd.lpSurface != surface->pixels ) {
 			SDL_SetError("DDraw didn't use SDL surface memory");
 			goto error_end;

_______________________________________________
SDL mailing list
[email protected]
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.