Re: Fail to build SDL-2.0.5, after enabling -std=c99 ...

Hi,

building with -std=3Dc99 (instead of gnu99) doesn't only change the syntax =

that's accepted by the compiler, but also what parts of headers are used.
All (or most?) things in standard headers that are not part of the C99 =

standard, like "GNU extensions" is not enabled (this is the "#define =

_GNU_SOURCE" stuff mentioned in manpages).
IMHO it's not very useful to use -std=3Dc99, especially for code like =

libSDL that needs to do operating-system specific things. Just use =

-std=3Dgnu99 (or even gnu89)..


Cheers,
Daniel

On 07.03.2017 02:01, JIA Pei wrote:
>
> Hi, Ryan:
>
>
> My current solution is to*change -std=3Dc99 to -std=3Dgnu99.*
>
> I'm testing your solution, which seems to be correct !!! However, I'm
> NOW facing some new issues:
>
> SDL2/SDL2-2.0.5/src/render/software/SDL_rotate.c:136:29:error: =91M_PI=92
> undeclared (first use in this function)
>         radangle =3D angle * (M_PI / -180.0); /* reverse the angle because
> our rotations are clockwise */
>
> SDL2/SDL2-2.0.5/src/events/SDL_quit.c:55:22:error: storage size of
> =91action=92 isn=92t known
>     struct sigaction action;
>
>
> I can easily solve the first problem  *'M_PI' hasn't been declared* by
> defining *M_PI *as*:*
>
>     *#ifndef M_PI*
>     *#define M_PI    3.14159265358979323846264338327950288   /* pi */*
>     *#endif*
>
>
>
> However, how to solve the second issue ????
> SDL2/SDL2-2.0.5/src/events/SDL_quit.c:55:22: error: storage size of
> =91action=92 isn=92t known
>     struct sigaction action;
>
>
> Cheers
>
>
> On Mon, Mar 6, 2017 at 2:00 PM, Ryan C. Gordon <[email protected]
> <mailto:[email protected]>> wrote:
>
>     On 3/3/17 5:13 PM, Sik the hedgehog wrote:
>
>         Try -std=3Dgnu99 (if I recall correctly)
>
>         Looks like the problem is using asm instead of a reserved keyword
>         (whoops). -std=3Dc99 will disable any extensions, -std=3Dgnu99 wi=
ll keep
>         them.
>
>
>     So the actual fix should be to change that to __asm__, right?
>
>     --ryan.
>
>
>
>
>     _______________________________________________
>     SDL mailing list
>     [email protected] <mailto:[email protected]>
>     http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org
>     <http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org>
>
>
>
>
> --
>
> Pei JIA, Ph.D.
>
> Email: [email protected] <mailto:[email protected]>
> cell in Canada:    +1 778-863-5816
> cell in China: +86 186-8244-3503
>
> Welcome to Vision Open
> http://www.visionopen.com
>
>
> _______________________________________________
> SDL mailing list
> [email protected]
> http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org
>