Re: [PATCH] ARC: Add GNU glob to ARC defconfigs

On Friday 06 February 2015 04:35 AM, Bernhard Reutner-Fischer wrote:
> On February 5, 2015 8:20:57 PM GMT+01:00, Rich Felker <[email protected]> wrote:
>> On Wed, Feb 04, 2015 at 03:58:41PM +0000, Anton Kolesov wrote:
>>> Now I've looked into more details of error cause and what happens is
>>> that those fields (gl_opendir, gl_readdir, gl_closedir, gl_stat) in
>>> glob_t in uclibc/include/glob.h are surrounded by "#ifdef
>>> __UCLIBC_HAS_GNU_GLOB__". "Make" might be built without GNU glob on
>>> target system because it contains its own copy in source tree and
>>> uses it when it detects that target system doesn’t have GNU glob.
>>> However the way it checks for GNU glob is not compatible with
>>> uClibc, because make/configure checks for "
>>> _GNU_GLOB_INTERFACE_VERSION == 1" as an indicator that GNU glob is
>>> present, but uclibc/gnu-versions.h defines
>>> _GNU_GLOB_INTERFACE_VERSION as 1 regardless of whether GNU glob is
>>> present in configuration. Thus make/configure decides that GNU glob
>>> is present when it is not, which causes further compilation error.
>> I think the definition of _GNU_GLOB_INTERFACE_VERSION just needs to be
>> moved inside the #ifdef __UCLIBC_HAS_GNU_GLOB__. uclibc should not be
>> reporting that it has GNU glob when it was built without it.
> Right.

Anton, are you going to spin a patch to that effect ?

-Vineet