Re: [PATCH 0/4] uClibc port to ARCv2 ISA

On Thursday 19 February 2015 02:34 AM, Bernhard Reutner-Fischer wrote:
> On February 18, 2015 1:11:03 PM GMT+01:00, Vineet Gupta <[email protected]> wrote:
>> Hi,
>>
>> Please find set of patches to support ARCv2 ISA basis of new HS family
>> of cores
> >from Synopsys.
>> http://www.synopsys.com/dw/ipdir.php?ds=arc-hs38-processor&elq_mid=5732&elq_cid=458802
>> http://www.synopsys.com/IP/ProcessorIP/ARCProcessors/arc-hs/Pages/default.aspx
>>
>> * 1/2 and 2/2 account for ARCv2 differences vs. existing ARCompact ISA.
> s/don;t/don't/
> The new arcv2_defconfig lacks GNU_GLOB.
>
> Do you want me to fix these 2 up before committing or do you want new patches?
>
>> * 3/4 and 4/4 fix handling of SYSCALL_ALIGN_64BIT in general.
>> It would seem that 4/4 is needed for any arch, but I've done this
>> under__arc__ to
>>  not possbily break other arches needing SYSCALL_ALIGN_64BIT
> What a pain. Let's expand this to other arches if you think it is right. Again, do you want me to adjust this or can you roll v2 patches?
>
> Thanks,

I can send a v2 for all. However 4/4 would need some say from ARCH maintainers and
perhaps u since u seem to have tinkered with that file the most :-)

xtensa enables UCLIBC_SYSCALL_ALIGN_64BIT. Their upstream kernel defines
__NR_sync_file_range but uses the sys_sync_file_range2 handler which is

SYSCALL_DEFINE4(sync_file_range2, int, fd, unsigned int, flags, loff_t, offset,
loff_t, nbytes)

So xtensa will be hosed if we switched their sync_file_range to standard
UCLIBC_SYSCALL_ALIGN_64BIT handling.
@Max, @Baruch, cn u please at orig patch below, and see if we can remove __arc__
from there (I guess we can't)

http://lists.uclibc.org/pipermail/uclibc/2015-February/048812.html

powerpc 32bit seems to use the "6, fd, flags" style arg passing so again it will
break if we switch them to use the stock UCLIBC_SYSCALL_ALIGN_64BIT.

Let me send that revised patch and see what people think. We will try to not
affect them but they need to shout now if something is not right.

-Vineet