Re: [PATCH 1/2] libc: fix setting return value and errno in fallocate()

On September 17, 2015 11:52:55 PM GMT+02:00, Rich Felker <[email protected]> wrote:
>On Thu, Sep 17, 2015 at 09:27:40PM +0200, Bernhard Reutner-Fischer
>wrote:
>> On September 17, 2015 6:16:48 PM GMT+02:00, Yuriy Kolerov
><[email protected]> wrote:
>> >Hi Rich.
>> >
>> >fallocate must return 0 or -1. However posix_fallocate my return an
>> >error code. So I think it would be better to allow posix_fallocate
>> >change errno as fallocate does it and fix posix_fallocate return
>value
>> >according to POSIX.
>> 
>> fallocate () should be implemented on top of posix_fallocate, yes.
>
>I don't think this is possible. fallocate has an extra mode argument
>which posix_fallocate lacks.

Right, didn't remember the mode arg.

Thanks,