Re: [PATCH v2 2/3] libc: fix sign extension in fallocate()

On Wednesday 23 September 2015 03:18 PM, Yuriy Kolerov wrote:
> I think it would be easier to call fallocate64 from fallocate:
>
> int attribute_hidden __libc_fallocate(int fd, int mode, __off_t offset, __off_t len)
> {
> # if __WORDSIZE == 32
> 	return fallocate64(fd, mode, offset, len);
> # elif __WORDSIZE == 64
> 	int ret;
> 	...

Indeed this is even better. You may wanna add a comment though which explains the
subtle upcasting.