Re: [PATCH v2] nptl: remove duplicate vfork() in libpthread

On Tuesday 20 October 2015 01:40 PM, Vineet Gupta wrote:
> On Monday 21 September 2015 09:28 AM, Vineet Gupta wrote:
>>>>>>>> Assuming above is correct, you want those macros to be removed from
>>>>>>>> nptl/*/**/vfork.S as well as libc/sysdeps/linux/*/vfork.S and
>>>>>> preferably replace
>>>>>>>> with a comment in case of latter set of files.
>>>>>>>>
>>>>>>>> Can this be done in 2 steps, so the first patch from Waldemar be
>>>>>> applied as it is
>>>>>>>> and then we do the cleanup to remove _PID from all the files (or is
>>>>>> it too much
>>>>>>>> churn cross arches)
>>>>
>>>> 2-step is fine for me too, as you prefer.
>> Waldermar's patch below while still valid, doesn't apply cleanly due to conflict
>> in a line(s) nuked already by your cleanup patch. Care to apply below with manual
>> fixups.
>> http://lists.uclibc.org/pipermail/uclibc/2014-September/048613.html
>>
>>
>> Regarding removing _PID stuff - I took a stab at it - so we inline the code
>> corresponding to {SAVE,RESTORE}_PID macros, however then it won't be valid/build
>> for LT.old - since tls.h / tcb_offset.h are not present there.
>>
>> -Vineet
> 
> 
> Ping !
> 

Ping !