Re: [uclibc-ng-devel] [PATCH] bits/byteswap-common.h: import recent headers from glibc
Waldemar Brodkorb <[email protected]> Fri, 1 Apr 2016 17:46:37 +0200
| Newsgroups | gmane.comp.lib.uclibc.general |
|---|---|
| Message-ID | <[email protected]> |
Hi Anthony, Anthony G. Basile wrote, > From: "Anthony G. Basile" <[email protected]> > > On systems where uClibc doesn't provide an arch specific byteswap.h, > we fall back on bits/byteswap-common.h. However, there is a bug > in this header in the __bswap_constant_64(x) macro. If, for example, > a double is passed, we get 'invalid operands to binary &' in which we > mismatch a 'double' and 'long long unsigned int'. The newer glibc > headers fix this and so we import them. Also, since the inclusion of > byteswap.h is not appropriate for assembly code, we guard a portion > of endian.h which uses byteswap.h from inclusion in any assembly. > > This is needed, for example, for f2fs-tools 1.6.0 on 32-bit big > endian PowerPC. Applied and pushed, Thanks Waldemar