Re: [PATCH] buildsys: Preserve arguments passed on

On 4/5/19 2:58 AM, Bernhard Reutner-Fischer wrote:
> On Thu, 4 Apr 2019 09:41:52 -0700
> Joseph Benden <[email protected]> wrote:
>
>> On 4/4/19 8:04 AM, Bernhard Reutner-Fischer wrote:
>>> On Fri, 22 Mar 2019 at 03:36, Joseph Benden <[email protected]> wrote:  
>>>> This patch ensures all arguments are quoted, during command-line
>>>> construction.
>>>>
>>>> This fixes compilation where spaces occur within the arguments.  
>>> Can you give me an example please?
>>> g++-uc -DFOO="BAR BAZ" -c ... ?
>>>
>>> TIA,
>>>  
>> Hi,
>>
>> Yes.
> I think we can simply avoid the whole issue.
> May i ask you to try the attached patch instead?
> TIA,

I do not have a simple way of testing, as I am depending on (slightly
outdated) uclibc++ inside of OpenWrt.

However, since arguments are now expanded via the shell, it should work
just fine - better in fact. I think your patch should go in.

Thanks!!
-Joe