Re: Fwd: cmake patches

Thanks. I am not privy to the patches email inbox, so this mailing list is
the way to reach me for CMake things. I'll review these when I have the
opportunity.

--Greg

On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <[email protected]> wrote:

>
> How to suggest improvements to the sword project?
>
>
>
> You did it the right way. It just is a bit on/off as a project. GHellings
> is the cmake pumpkin holder as far as I know. I bcc him on a different
> email address.
>
> Peter
>
>
>
> BR,
>
> Zdenko
>
> ---------- Forwarded message ---------
> From: ZdPo Ster <[email protected]>
> Date: Sun, 6 Nov 2022 at 22:22
> Subject: cmake patches
> To: <[email protected]>
>
>
> Hello,
>
> please find 3 few patches related to cmake build (tested on windows with
> MSVC 2019):
>
>    1. cmake_fix_deprecation.patch - cmake version 3.23.2 produce
>    depreciation warning for old minimum version, co IMO it is time to increase
>    expected cmake version
>    2. cmake_fix_msvc.patch - there is no "/O3" options in current MSVC[1]
>    3. cmake_git_svn.patch - I use git svn for accessing code, but cmake
>    produce error because of missing svn executable. He is patch that fixed it
>    + code for detecting svn revision (MYSVN_WC_REVISION) from git
>
> [1]
> https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160
>
> Zdenko
>
> _______________________________________________
> sword-devel mailing list: [email protected]
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
>

_______________________________________________
sword-devel mailing list: [email protected]
http://crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page