Re: Endless looping
Michael Johnson <[email protected]> Sat, 21 Jun 2025 13:06:04 -1000
| Newsgroups | gmane.comp.literature.sword.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============2899852288864264693== Content-Type: multipart/alternative; boundary="------------kSk0gnDc1dB0TaiiBvbo3Lqn" Content-Language: en-US This is a multi-part message in MIME format. --------------kSk0gnDc1dB0TaiiBvbo3Lqn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thank you. Sorry I didn't get it tested sooner... I was traveling then=20 came home to a dead computer, so had a lot of work recovering from that=20 first. But I really appreciate your work on this! On 6/19/25 14:22, DM Smith wrote: > This has been committed. To use, compile SWORD from SVN. > > In Him, > DM > >> On Jun 16, 2025, at 5:07=E2=80=AFPM, DM Smith<[email protected]> wr= ote: >> >> Pinoaffe, Michael, >> >> Attached is a patch that will fix the endless looping bug. >> >> The problem was in a verse in a chapter that was not in the chosen vers= ification. Nitty gritty, incrementing a bad verse should have set an error= . The fix for that was in src/keys/versekey.cpp in checkBounds. >> >> That uncovered another problem in osis2mod that such verses were not pr= operly placed at the end of the book in the last chapter. >> >> Hope you can build this locally before we can check in this patch. I wa= nt Troy to review it, especially for unintended side effects. >> >> In Him, >> DM >> >> <osis2mod-infinite-loop.patch> >> >>> On Apr 3, 2025, at 3:39=E2=80=AFAM, pinoaffe<[email protected]> wrote= : >>> >>> DM Smith<[email protected]> writes: >>> >>>> Can you supply a mock osis xml that reliably goes into an infinite lo= op? I=E2=80=99ve heard reports of this >>>> but cannot reproduce. >>> I've attached a file test.xml that goes into an infinite loop when I r= un >>> something like `osis2mod /tmp test.xml` on osis2mod version $Rev: 3769= $ >>> (SWORD: 1.9.0) >>> >>> I don't know for sure whether this is the issue that was reported, but >>> I've encountered this before: osis2mod seems to go into an infinite lo= op >>> when it encounters a chapter that is not in the versification. This (= or >>> similar infinite-looping issues with osis2mod) has been reported by >>> several others on this mailing list. >>> >> <test.xml> >>> >>> Kind regards, >>> pinoaffe >>> _______________________________________________ >>> sword-devel mailing list:[email protected] >>> http://crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page > _______________________________________________ > sword-devel mailing list:[email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page =2D-=20 signature Peace, */Michael Johnson/** 26 HIWALANI LOOP =E2=80=A2 MAKAWAO HI 96768-8747*=E2=80=A2 USA mljohnson.org <https://mljohnson.org/> =E2=80=A2 eBible.org <https://eBibl= e.org>=20 =E2=80=A2 WorldEnglish.Bible <https://WorldEnglish.Bible> =E2=80=A2 PNG.Bi= ble=20 <https://PNG.Bible> Signal/Telegram/WhatsApp/Telephone: +1 808-333-6921 Telegram: @kahunapule =E2=80=A2 Facebook: fb.me/kahunapule=20 <https://www.facebook.com/kahunapule> --------------kSk0gnDc1dB0TaiiBvbo3Lqn Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-= 8"> </head> <body> <p>Thank you. Sorry I didn't get it tested sooner... I was traveling then came home to a dead computer, so had a lot of work recovering from that first. But I really appreciate your work on this!<br> </p> <div class=3D"moz-cite-prefix">On 6/19/25 14:22, DM Smith wrote:<br> </div> <blockquote type=3D"cite" cite=3D"mid:6AD340A3-CB3C-4989-9EEB-871E7E94E708-ZKNsLcePPwPNLxjTenLetw@public.gmane.org"> <pre wrap=3D"" class=3D"moz-quote-pre">This has been committed. To u= se, compile SWORD from SVN. In Him, DM </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">On Jun 16, 2025, at 5:07=E2= =80=AFPM, DM Smith <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:dmsmi= [email protected]"><[email protected]></a> wrote: Pinoaffe, Michael, Attached is a patch that will fix the endless looping bug. The problem was in a verse in a chapter that was not in the chosen versifi= cation. Nitty gritty, incrementing a bad verse should have set an error. T= he fix for that was in src/keys/versekey.cpp in checkBounds. That uncovered another problem in osis2mod that such verses were not prope= rly placed at the end of the book in the last chapter. Hope you can build this locally before we can check in this patch. I want = Troy to review it, especially for unintended side effects. In Him, DM <osis2mod-infinite-loop.patch> </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">On Apr 3, 2025, at 3:39= =E2=80=AFAM, pinoaffe <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:pi= [email protected]"><[email protected]></a> wrote: DM Smith <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:dmsmith@crosswi= re.org"><[email protected]></a> writes: </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">Can you supply a mock o= sis xml that reliably goes into an infinite loop? I=E2=80=99ve heard repor= ts of this but cannot reproduce. </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre">I've attached a file test= .xml that goes into an infinite loop when I run something like `osis2mod /tmp test.xml` on osis2mod version $Rev: 3769 $ (SWORD: 1.9.0) I don't know for sure whether this is the issue that was reported, but I've encountered this before: osis2mod seems to go into an infinite loop when it encounters a chapter that is not in the versification. This (or similar infinite-looping issues with osis2mod) has been reported by several others on this mailing list. </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"><test.xml> </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre"> Kind regards, pinoaffe _______________________________________________ sword-devel mailing list: <a class=3D"moz-txt-link-abbreviated" href=3D"ma= ilto:[email protected]">[email protected]</a> <a class=3D"moz-txt-link-freetext" href=3D"http://crosswire.org/mailman/li= stinfo/sword-devel">http://crosswire.org/mailman/listinfo/sword-devel</a> Instructions to unsubscribe/change your settings at above page </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"> </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"> _______________________________________________ sword-devel mailing list: <a class=3D"moz-txt-link-abbreviated" href=3D"ma= ilto:[email protected]">[email protected]</a> <a class=3D"moz-txt-link-freetext" href=3D"http://crosswire.org/mailman/li= stinfo/sword-devel">http://crosswire.org/mailman/listinfo/sword-devel</a> Instructions to unsubscribe/change your settings at above page </pre> </blockquote> <div class=3D"moz-signature">-- <br> <meta http-equiv=3D"CONTENT-TYPE" content=3D"text/html; charset=3DUT= F-8"> <title>signature</title> <p><font color=3D"#000000">Peace,<br> <b><big><i>Michael Johnson</i></big></b></font><b><br> <font color=3D"#000070"> 26 HIWALANI LOOP =E2=80=A2 MAKAWAO HI 96768-8747</font></b><fo= nt color=3D"#000070"> =E2=80=A2 USA<br> <a href=3D"https://mljohnson.org/">mljohnson.org</a> =E2=80=A2 <= a href=3D"https://eBible.org">eBible.org</a> =E2=80=A2 <a href=3D"https://WorldEnglish.Bible">WorldEnglish.Bible</a> =E2= =80=A2 <a href=3D"https://PNG.Bible">PNG.Bible</a><br> Signal/Telegram/WhatsApp/Telephone: +1 808-333-6921<br> Telegram: @kahunapule =E2=80=A2 <a href=3D"https://www.facebook.com/kahunapule">Facebook: fb.me/kahunapule</a></font></p> </div> </body> </html> --------------kSk0gnDc1dB0TaiiBvbo3Lqn-- --===============2899852288864264693== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sword-devel mailing list: [email protected] http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page --===============2899852288864264693==--