Re: Fwd: cmake patches
Greg Hellings <[email protected]> Tue, 19 Aug 2025 22:22:04 -0500
| Newsgroups | gmane.comp.literature.sword.devel |
|---|---|
| Message-ID | <CAHxvOVKZzefb0tS1WQTjhTKS7=6HmH0zXoTuqpOJQz_=AAN=Qw@mail.gmail.com> |
--===============8225251402265106466== Content-Type: multipart/alternative; boundary="000000000000b416b7063cc37a61" --000000000000b416b7063cc37a61 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable What are your needs for using the CMake toolchain? It is strictly inferior to the autotools system with the exception of supporting Python and Perl more robustly. But I never was able to get it handling all of the Unicode tests perfectly, and even I don't use it anymore for the places where I maintain Sword builds. The two initial reasons for putting it together were MinGW support which was superior at that time in CMake than autotools (this is no longer the case) and the Python/Perl bindings. But even those I would likely move over to autotools at this point when the need for an update appears. --Greg On Mon, Aug 18, 2025, 4:25=E2=80=AFAM ZdPo Ster <[email protected]> wrote: > Any idea when cmake build will be fixed & improved? > Recent svn version can not be built with cmake. Minimum change to at leas= t > finish configure requires: > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 676353b5..bd3e6f81 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -11,13 +11,14 @@ > # of their own GPLv2 license and all copyright is transferred to them fo= r > # all posterity and eternity, wherever such transfer is possible. Where > it is > # not, then this file is released under the GPLv2 by myself. > +CMAKE_MINIMUM_REQUIRED(VERSION 3.10.0) > > CMAKE_POLICY(SET CMP0010 NEW) > include(FindSubversion) > Subversion_WC_INFO(${CMAKE_CURRENT_SOURCE_DIR} MYSVN IGNORE_SVN_FAILURE) > > PROJECT(libsword CXX C) > -CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0) > + > SET(SWORD_VERSION 1.9.0) > if(DEFINED MYSVN_WC_REVISION) > SET(SWORD_VERSION ${SWORD_VERSION}.${MYSVN_WC_REVISION}) > > --Zdenko > > On Fri, 17 Mar 2023 at 19:25, Greg Hellings <[email protected]> > wrote: > >> Indeed. It's not a principled stand that I'm refusing to get Subversion >> going. It's simply that it's too much work that I haven't bothered and >> don't foresee doing so anytime soon. >> >> And, with no setup to automatically test the scripts in all the >> environments they must support, it's not likely others are willing to >> commit this on my behalf. >> >> --Greg >> >> On Sun, Mar 12, 2023, 09:42 Peter von Kaehne <[email protected]> wrote: >> >>> I think you misunderstood Greg. >>> >>> There is a long campaign and strong feeling to have the project on Git >>> but there is no agreement or movement to that. And it seems Greg is pau= sing >>> his contributions until that matter is resolved. >>> >>> Peter >>> >>> Sent from my phone. Please forgive misspellings and weird =E2=80=9Ccorr= ections=E2=80=9D >>> >>> On 12 Mar 2023, at 15:51, ZdPo Ster <[email protected]> wrote: >>> >>> =EF=BB=BF >>> I am sorry, but I did not get the point of your reply. >>> I do not use subversion - I use git-svn as proposed several months ago >>> on this forum. But current cmake configuration expects everybody to use >>> subversion, which is wrong. >>> These patches improve cmake build: >>> >>> - that will work also with git-svn >>> - MSVC build >>> - fix depreciated >>> >>> AFAIK it should cause no harm for other combinations, just improve >>> current state. >>> >>> Zdenko >>> >>> On Thu, 9 Mar 2023 at 23:18, Greg Hellings <[email protected]> >>> wrote: >>> >>>> I've never bothered to get Subversion setup on my local machine. >>>> Remembering the setup, plus my credentials, and how to use it is more = labor >>>> than I've been willing to spend on this effort. If, in the future, I >>>> overcome that inertia then I'll happily test and apply this patch. >>>> >>>> --Greg >>>> >>>> On Sat, Feb 25, 2023 at 5:34 AM ZdPo Ster <[email protected]> wrote: >>>> >>>>> Any update on this (after 3.5 months)? >>>>> >>>>> Zdenko >>>>> >>>>> On Sat, 26 Nov 2022 at 21:53, Greg Hellings <[email protected]> >>>>> wrote: >>>>> >>>>>> Thanks. I am not privy to the patches email inbox, so this mailing >>>>>> list is the way to reach me for CMake things. I'll review these when= I have >>>>>> the opportunity. >>>>>> >>>>>> --Greg >>>>>> >>>>>> On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <[email protected]> wrote: >>>>>> >>>>>>> >>>>>>> How to suggest improvements to the sword project? >>>>>>> >>>>>>> >>>>>>> >>>>>>> You did it the right way. It just is a bit on/off as a project. >>>>>>> GHellings is the cmake pumpkin holder as far as I know. I bcc him o= n a >>>>>>> different email address. >>>>>>> >>>>>>> Peter >>>>>>> >>>>>>> >>>>>>> >>>>>>> BR, >>>>>>> >>>>>>> Zdenko >>>>>>> >>>>>>> ---------- Forwarded message --------- >>>>>>> From: ZdPo Ster <[email protected]> >>>>>>> Date: Sun, 6 Nov 2022 at 22:22 >>>>>>> Subject: cmake patches >>>>>>> To: <[email protected]> >>>>>>> >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> please find 3 few patches related to cmake build (tested on windows >>>>>>> with MSVC 2019): >>>>>>> >>>>>>> 1. cmake_fix_deprecation.patch - cmake version 3.23.2 produce >>>>>>> depreciation warning for old minimum version, co IMO it is time = to increase >>>>>>> expected cmake version >>>>>>> 2. cmake_fix_msvc.patch - there is no "/O3" options in current >>>>>>> MSVC[1] >>>>>>> 3. cmake_git_svn.patch - I use git svn for accessing code, but >>>>>>> cmake produce error because of missing svn executable. He is pat= ch that >>>>>>> fixed it + code for detecting svn revision (MYSVN_WC_REVISION) f= rom git >>>>>>> >>>>>>> [1] >>>>>>> https://learn.microsoft.com/en-us/cpp/build/reference/o-options-opt= imize-code?view=3Dmsvc-160 >>>>>>> >>>>>>> Zdenko >>>>>>> >>>>>>> _______________________________________________ >>>>>>> sword-devel mailing list: [email protected] >>>>>>> http://crosswire.org/mailman/listinfo/sword-devel >>>>>>> Instructions to unsubscribe/change your settings at above page >>>>>>> >>>>>>> _______________________________________________ >>>>>> sword-devel mailing list: [email protected] >>>>>> http://crosswire.org/mailman/listinfo/sword-devel >>>>>> Instructions to unsubscribe/change your settings at above page >>>>>> >>>>> _______________________________________________ >>>>> sword-devel mailing list: [email protected] >>>>> http://crosswire.org/mailman/listinfo/sword-devel >>>>> Instructions to unsubscribe/change your settings at above page >>>>> >>>> _______________________________________________ >>>> sword-devel mailing list: [email protected] >>>> http://crosswire.org/mailman/listinfo/sword-devel >>>> Instructions to unsubscribe/change your settings at above page >>>> >>> _______________________________________________ >>> sword-devel mailing list: [email protected] >>> http://crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >>> >>> _______________________________________________ >>> sword-devel mailing list: [email protected] >>> http://crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >>> >> _______________________________________________ >> sword-devel mailing list: [email protected] >> http://crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page >> > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > --000000000000b416b7063cc37a61 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">What are your needs for using the CMake toolchain? It is = strictly inferior to the autotools system with the exception of supporting = Python and Perl more robustly. But I never was able to get it handling all = of the Unicode tests perfectly, and even I don't use it anymore for the= places where I maintain Sword builds. The two initial reasons for putting = it together were MinGW support which was superior at that time in CMake tha= n autotools (this is no longer the case) and the Python/Perl bindings. But = even those I would likely move over to autotools at this point when the nee= d for an update appears.<div dir=3D"auto"><br><div dir=3D"auto">--Greg</div= ></div></div><br><div class=3D"gmail_quote gmail_quote_container"><div dir= =3D"ltr" class=3D"gmail_attr">On Mon, Aug 18, 2025, 4:25=E2=80=AFAM ZdPo St= er <<a href=3D"mailto:[email protected]">[email protected]</a>> wro= te:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b= order-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><div>Any = idea when cmake build will be fixed & improved?<br></div><div>Recent sv= n version can not be built with cmake. Minimum change to at least finish co= nfigure requires:</div><div><br></div>diff --git a/CMakeLists.txt b/CMakeLi= sts.txt<br>index 676353b5..bd3e6f81 100644<br>--- a/CMakeLists.txt<br>+++ b= /CMakeLists.txt<br>@@ -11,13 +11,14 @@<br>=C2=A0# of their own GPLv2 licens= e and all copyright is transferred to them for<br>=C2=A0# all posterity and= eternity, wherever such transfer is possible.=C2=A0 Where it is<br>=C2=A0#= not, then this file is released under the GPLv2 by myself.<br>+CMAKE_MINIM= UM_REQUIRED(VERSION 3.10.0)<br><br>=C2=A0CMAKE_POLICY(SET CMP0010 NEW)<br>= =C2=A0include(FindSubversion)<br>=C2=A0Subversion_WC_INFO(${CMAKE_CURRENT_S= OURCE_DIR} MYSVN IGNORE_SVN_FAILURE)<br><br>=C2=A0PROJECT(libsword CXX C)<b= r>-CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0)<br>+<br>=C2=A0SET(SWORD_VERSION 1.= 9.0)<br>=C2=A0if(DEFINED MYSVN_WC_REVISION)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 = SET(SWORD_VERSION ${SWORD_VERSION}.${MYSVN_WC_REVISION})<br></div><div><br>= </div><div>--Zdenko</div></div><br><div class=3D"gmail_quote"><div dir=3D"l= tr" class=3D"gmail_attr">On Fri, 17 Mar 2023 at 19:25, Greg Hellings <<a= href=3D"mailto:[email protected]" target=3D"_blank" rel=3D"noreferre= r">[email protected]</a>> wrote:<br></div><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex"><div dir=3D"auto">Indeed. It's not a principl= ed stand that I'm refusing to get Subversion going. It's simply tha= t it's too much work that I haven't bothered and don't foresee = doing so anytime soon.<div dir=3D"auto"><br></div><div dir=3D"auto">And, wi= th no setup to automatically test the scripts in all the environments they = must support, it's not likely others are willing to commit this on my b= ehalf.<br><div dir=3D"auto"><br></div><div dir=3D"auto">--Greg</div></div><= /div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">O= n Sun, Mar 12, 2023, 09:42 Peter von Kaehne <<a href=3D"mailto:refdoc@gm= x.net" target=3D"_blank" rel=3D"noreferrer">[email protected]</a>> wrote:<b= r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex= ;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto"= >I think you misunderstood Greg.=C2=A0<div><br></div><div>There is a long c= ampaign and strong feeling to have the project on Git but there is no agree= ment or movement to that. And it seems Greg is pausing his contributions un= til that matter is resolved.=C2=A0</div><div><br></div><div>Peter<br><br><d= iv dir=3D"ltr">Sent from my phone. Please forgive misspellings and weird = =E2=80=9Ccorrections=E2=80=9D</div><div dir=3D"ltr"><br><blockquote type=3D= "cite">On 12 Mar 2023, at 15:51, ZdPo Ster <<a href=3D"mailto:zdposter@g= mail.com" rel=3D"noreferrer noreferrer" target=3D"_blank">[email protected]= m</a>> wrote:<br><br></blockquote></div><blockquote type=3D"cite"><div d= ir=3D"ltr">=EF=BB=BF<div dir=3D"ltr"><div>I am sorry, but I did not get the= point of your reply.</div><div>I do not use subversion - I use git-svn as = proposed several months ago on this forum. But current cmake configuration = expects everybody to use subversion, which is wrong.<br></div><div>These pa= tches improve cmake build:</div><div><ul><li>=C2=A0that will work also with= =20 git-svn <br></li><li>MSVC build</li><li>fix depreciated</li></ul><div>AFAIK= it should cause no harm for other combinations, just improve current state= .</div><div><br></div><div>Zdenko<br></div></div></div><br><div class=3D"gm= ail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, 9 Mar 2023 at 23:1= 8, Greg Hellings <<a href=3D"mailto:[email protected]" rel=3D"nore= ferrer noreferrer" target=3D"_blank">[email protected]</a>> wrote:= <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr= "><div>I've never bothered to get Subversion setup on my local machine.= Remembering the setup, plus my credentials, and how to use it is more labo= r than I've been willing to spend on this effort. If, in the future, I = overcome that inertia then I'll happily test and apply this patch.</div= ><div><br></div><div>--Greg<br></div></div><br><div class=3D"gmail_quote"><= div dir=3D"ltr" class=3D"gmail_attr">On Sat, Feb 25, 2023 at 5:34 AM ZdPo S= ter <<a href=3D"mailto:[email protected]" rel=3D"noreferrer noreferrer"= target=3D"_blank">[email protected]</a>> wrote:<br></div><blockquote c= lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli= d rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>Any update on th= is (after 3.5 months)?</div><div><br></div><div>Zdenko<br></div></div><br><= div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, 26 = Nov 2022 at 21:53, Greg Hellings <<a href=3D"mailto:greg.hellings@gmail.= com" rel=3D"noreferrer noreferrer" target=3D"_blank">[email protected]= m</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin= :0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"= ><div dir=3D"auto">Thanks. I am not privy to the patches email inbox, so th= is mailing list is the way to reach me for CMake things. I'll review th= ese when I have the opportunity.<div dir=3D"auto"><br></div><div dir=3D"aut= o">--Greg</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class= =3D"gmail_attr">On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <<a href=3D= "mailto:[email protected]" rel=3D"noreferrer noreferrer" target=3D"_blank">ref= [email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex"><div dir=3D"auto"><br><blockquote type=3D"cite"><div dir=3D"ltr"= ><div dir=3D"ltr"><div>How to suggest improvements to the sword project?</d= iv></div></div></blockquote><div><br></div><div><br></div>You did it the ri= ght way. It just is a bit on/off as a project. GHellings is the cmake pumpk= in holder as far as I know. I bcc him on a different email address.=C2=A0<d= iv><br></div><div>Peter<br><div><br></div><div><br></div><div><blockquote t= ype=3D"cite"><div dir=3D"ltr"><div dir=3D"ltr"><div><br></div><div>BR,</div= ><div><br></div><div>Zdenko<br></div><div><br><div class=3D"gmail_quote"><d= iv dir=3D"ltr" class=3D"gmail_attr">---------- Forwarded message ---------<= br>From: <b class=3D"gmail_sendername" dir=3D"auto">ZdPo Ster</b> <span dir= =3D"auto"><<a href=3D"mailto:[email protected]" rel=3D"noreferrer noref= errer noreferrer" target=3D"_blank">[email protected]</a>></span><br>Da= te: Sun, 6 Nov 2022 at 22:22<br>Subject: cmake patches<br>To: <<a href= =3D"mailto:[email protected]" rel=3D"noreferrer noreferrer noreferrer" = target=3D"_blank">[email protected]</a>><br></div><br><br><div dir= =3D"ltr"><div>Hello,</div><div><br></div><div>please find 3 few patches rel= ated to cmake build (tested on=C2=A0windows with MSVC 2019):</div><div><ol>= <li>cmake_fix_deprecation.patch - cmake version 3.23.2 produce depreciation= warning for old minimum version, co IMO it is time to increase expected cm= ake version</li><li>cmake_fix_msvc.patch - there is no "/O3" opti= ons in current MSVC[1]</li><li>cmake_git_svn.patch - I use git svn for acce= ssing code, but cmake produce error because of missing svn executable. He i= s patch that fixed it + code for detecting svn revision (MYSVN_WC_REVISION)= from git</li></ol><div></div><div>[1] <a href=3D"https://learn.microsoft.c= om/en-us/cpp/build/reference/o-options-optimize-code?view=3Dmsvc-160" rel= =3D"noreferrer noreferrer noreferrer" target=3D"_blank">https://learn.micro= soft.com/en-us/cpp/build/reference/o-options-optimize-code?view=3Dmsvc-160<= /a></div><div><br></div><div>Zdenko<br></div></div></div> </div></div></div> </div></blockquote></div></div></div><div dir=3D"auto" role=3D"textbox" ari= a-label=3D"Message Body"><div><div><blockquote type=3D"cite"><div dir=3D"lt= r"></div></blockquote></div></div></div><div dir=3D"auto" role=3D"textbox" = aria-label=3D"Message Body"><div><div><blockquote type=3D"cite"><div dir=3D= "ltr"></div></blockquote></div></div></div><div dir=3D"auto"><div><div><blo= ckquote type=3D"cite"><div dir=3D"ltr"><span>______________________________= _________________</span><br><span>sword-devel mailing list: <a href=3D"mail= to:[email protected]" rel=3D"noreferrer noreferrer noreferrer" targ= et=3D"_blank">[email protected]</a></span><br><span><a href=3D"http= ://crosswire.org/mailman/listinfo/sword-devel" rel=3D"noreferrer noreferrer= noreferrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-= devel</a></span><br><span>Instructions to unsubscribe/change your settings = at above page</span><br></div></blockquote></div></div></div></blockquote><= /div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" rel= =3D"noreferrer noreferrer" target=3D"_blank">[email protected]</a><= br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/= listinfo/sword-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" rel= =3D"noreferrer noreferrer" target=3D"_blank">[email protected]</a><= br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/= listinfo/sword-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" rel= =3D"noreferrer noreferrer" target=3D"_blank">[email protected]</a><= br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/= listinfo/sword-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> <span>_______________________________________________</span><br><span>sword= -devel mailing list: <a href=3D"mailto:[email protected]" rel=3D"no= referrer noreferrer" target=3D"_blank">[email protected]</a></span>= <br><span><a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel= =3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/l= istinfo/sword-devel</a></span><br><span>Instructions to unsubscribe/change = your settings at above page</span><br></div></blockquote></div></div>______= _________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" rel= =3D"noreferrer noreferrer" target=3D"_blank">[email protected]</a><= br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/= listinfo/sword-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" targ= et=3D"_blank" rel=3D"noreferrer">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sw= ord-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" targ= et=3D"_blank" rel=3D"noreferrer">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sw= ord-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> --000000000000b416b7063cc37a61-- --===============8225251402265106466== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sword-devel mailing list: [email protected] http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page --===============8225251402265106466==--