Re: Fwd: cmake patches
ZdPo Ster <[email protected]> Wed, 20 Aug 2025 07:50:48 +0200
| Newsgroups | gmane.comp.literature.sword.devel |
|---|---|
| Message-ID | <CAC=ZCwwoV1uaVhdErk2JcUS6d1G7DnrrxCy02iTyNGz8ac7mKg@mail.gmail.com> |
--===============6272776381193088983== Content-Type: multipart/alternative; boundary="000000000000913961063cc58eba" --000000000000913961063cc58eba Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable My personal aim is to build the sword on windows with msvc and/or clang. So autotools is not an option (compared to linux). I have several years experience with cmake and building c++ multiplatform projects, so I can help with this. I believe bringing the sword to "msvc (and git ;-) ) world" could bring another contributor to this project. Zdenko On Wed, 20 Aug 2025 at 05:55, Greg Hellings <[email protected]> wrote= : > > > On Tue, Aug 19, 2025, 10:34=E2=80=AFPM Aaron Rainbolt <[email protected]= om> > wrote: > >> FWIW (and as you well know since you're still a co-maintainer of it), >> the SWORD package for Fedora relies on the CMake toolchain. >> > > Indeed. But it really shouldn't. Mea culpa on that! The main reason I > never switched it is because it is the only currently easy access I have = to > the bindings without always needing to stand up a development environment > everywhere. > > Personally, I've always used CMake rather than autotools for building >> SWORD when doing custom builds of it. I was under the impression that >> the autotools toolchain was deprecated. >> > > No. Autotools is the source of truth. CMake is a "best effort" alternativ= e > that started out really as just a way for me to enable Python bindings an= d > Windows builds. But now autotools supports Windows (cross-build) targets > just as readily as it does Unix targets. And people who want to use Pytho= n > or Perl are well served by the existing CMake toolchain. > > Ideally the bindings should be pulled out to a separate package and > uploaded to, for example, PyPI. (Peter - do you still use the Perl > bindings? I think you might have been the only one to ever use those, but > do you still?) That way they are available through that language's native > tooling. I did that, once upon a time, but adding tooling to automaticall= y > regenerate the Swig binding would take that a long way. > > >> As for why one would use CMake instead, you could probably quote >> whatever the usual arguments are for using CMake instead of autotools >> > > I've never actually seen such a debate. Despite having no qualms with > shell script, I still find CMake more legible. But autotools is well know= n > and readily supported almost anywhere. Except for Windows build hosts. An= d > early on I was hoping to provide a way to build with MSVC through it to > replace the old handcrafted Windows build scripts. But when MinGW had ful= ly > matured, that need was eliminated. > > (easier to audit for security as opposed to autogenerated >> multi-thousand-line-long shell scripts written in convoluted >> antediluvian POSIX sh language designed to work on older versions of >> Solaris and that check for bugs existing in assorted other ancient and >> likely entirely unused flavors of UNIX among other things, you don't >> have to build the build system itself and potentially run into >> insurmountable issues in so doing if trying to build SWORD on a system >> older or newer than the ones upstream uses, modifying the build system >> to add extra source files or move things around only gives one a >> migraine rather than making their head explode, etc.). I personally >> would like to not have to change the Fedora SWORD package from using >> CMake, and would ask for help if the CMake side of things broke >> because I don't want to fight with autoheadache. >> > > The problem is, those antique targets are still actively supported by > Sword, so using autotools is still a really good choice. Personally I don= 't > even dabble in C these days unless I need to edit someone else's code. Bu= t > more modern languages don't really target those older systems, so autotoo= ls > for a C++ code base is pretty much the best thing going to service all of > breadth of systems that Sword supports. > > --Greg > > >> On Tue, Aug 19, 2025 at 10:22=E2=80=AFPM Greg Hellings <greg.hellings@gm= ail.com> >> wrote: >> > >> > What are your needs for using the CMake toolchain? It is strictly >> inferior to the autotools system with the exception of supporting Python >> and Perl more robustly. But I never was able to get it handling all of t= he >> Unicode tests perfectly, and even I don't use it anymore for the places >> where I maintain Sword builds. The two initial reasons for putting it >> together were MinGW support which was superior at that time in CMake tha= n >> autotools (this is no longer the case) and the Python/Perl bindings. But >> even those I would likely move over to autotools at this point when the >> need for an update appears. >> > >> > --Greg >> > >> > On Mon, Aug 18, 2025, 4:25=E2=80=AFAM ZdPo Ster <[email protected]> w= rote: >> >> >> >> Any idea when cmake build will be fixed & improved? >> >> Recent svn version can not be built with cmake. Minimum change to at >> least finish configure requires: >> >> >> >> diff --git a/CMakeLists.txt b/CMakeLists.txt >> >> index 676353b5..bd3e6f81 100644 >> >> --- a/CMakeLists.txt >> >> +++ b/CMakeLists.txt >> >> @@ -11,13 +11,14 @@ >> >> # of their own GPLv2 license and all copyright is transferred to the= m >> for >> >> # all posterity and eternity, wherever such transfer is possible. >> Where it is >> >> # not, then this file is released under the GPLv2 by myself. >> >> +CMAKE_MINIMUM_REQUIRED(VERSION 3.10.0) >> >> >> >> CMAKE_POLICY(SET CMP0010 NEW) >> >> include(FindSubversion) >> >> Subversion_WC_INFO(${CMAKE_CURRENT_SOURCE_DIR} MYSVN >> IGNORE_SVN_FAILURE) >> >> >> >> PROJECT(libsword CXX C) >> >> -CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0) >> >> + >> >> SET(SWORD_VERSION 1.9.0) >> >> if(DEFINED MYSVN_WC_REVISION) >> >> SET(SWORD_VERSION ${SWORD_VERSION}.${MYSVN_WC_REVISION}) >> >> >> >> --Zdenko >> >> >> >> On Fri, 17 Mar 2023 at 19:25, Greg Hellings <[email protected]> >> wrote: >> >>> >> >>> Indeed. It's not a principled stand that I'm refusing to get >> Subversion going. It's simply that it's too much work that I haven't >> bothered and don't foresee doing so anytime soon. >> >>> >> >>> And, with no setup to automatically test the scripts in all the >> environments they must support, it's not likely others are willing to >> commit this on my behalf. >> >>> >> >>> --Greg >> >>> >> >>> On Sun, Mar 12, 2023, 09:42 Peter von Kaehne <[email protected]> wrote: >> >>>> >> >>>> I think you misunderstood Greg. >> >>>> >> >>>> There is a long campaign and strong feeling to have the project on >> Git but there is no agreement or movement to that. And it seems Greg is >> pausing his contributions until that matter is resolved. >> >>>> >> >>>> Peter >> >>>> >> >>>> Sent from my phone. Please forgive misspellings and weird >> =E2=80=9Ccorrections=E2=80=9D >> >>>> >> >>>> On 12 Mar 2023, at 15:51, ZdPo Ster <[email protected]> wrote: >> >>>> >> >>>> =EF=BB=BF >> >>>> I am sorry, but I did not get the point of your reply. >> >>>> I do not use subversion - I use git-svn as proposed several months >> ago on this forum. But current cmake configuration expects everybody to = use >> subversion, which is wrong. >> >>>> These patches improve cmake build: >> >>>> >> >>>> that will work also with git-svn >> >>>> MSVC build >> >>>> fix depreciated >> >>>> >> >>>> AFAIK it should cause no harm for other combinations, just improve >> current state. >> >>>> >> >>>> Zdenko >> >>>> >> >>>> On Thu, 9 Mar 2023 at 23:18, Greg Hellings <[email protected]= > >> wrote: >> >>>>> >> >>>>> I've never bothered to get Subversion setup on my local machine. >> Remembering the setup, plus my credentials, and how to use it is more la= bor >> than I've been willing to spend on this effort. If, in the future, I >> overcome that inertia then I'll happily test and apply this patch. >> >>>>> >> >>>>> --Greg >> >>>>> >> >>>>> On Sat, Feb 25, 2023 at 5:34 AM ZdPo Ster <[email protected]> >> wrote: >> >>>>>> >> >>>>>> Any update on this (after 3.5 months)? >> >>>>>> >> >>>>>> Zdenko >> >>>>>> >> >>>>>> On Sat, 26 Nov 2022 at 21:53, Greg Hellings < >> [email protected]> wrote: >> >>>>>>> >> >>>>>>> Thanks. I am not privy to the patches email inbox, so this >> mailing list is the way to reach me for CMake things. I'll review these >> when I have the opportunity. >> >>>>>>> >> >>>>>>> --Greg >> >>>>>>> >> >>>>>>> On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <[email protected]> >> wrote: >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> How to suggest improvements to the sword project? >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> You did it the right way. It just is a bit on/off as a project. >> GHellings is the cmake pumpkin holder as far as I know. I bcc him on a >> different email address. >> >>>>>>>> >> >>>>>>>> Peter >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> BR, >> >>>>>>>> >> >>>>>>>> Zdenko >> >>>>>>>> >> >>>>>>>> ---------- Forwarded message --------- >> >>>>>>>> From: ZdPo Ster <[email protected]> >> >>>>>>>> Date: Sun, 6 Nov 2022 at 22:22 >> >>>>>>>> Subject: cmake patches >> >>>>>>>> To: <[email protected]> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> Hello, >> >>>>>>>> >> >>>>>>>> please find 3 few patches related to cmake build (tested on >> windows with MSVC 2019): >> >>>>>>>> >> >>>>>>>> cmake_fix_deprecation.patch - cmake version 3.23.2 produce >> depreciation warning for old minimum version, co IMO it is time to incre= ase >> expected cmake version >> >>>>>>>> cmake_fix_msvc.patch - there is no "/O3" options in current >> MSVC[1] >> >>>>>>>> cmake_git_svn.patch - I use git svn for accessing code, but >> cmake produce error because of missing svn executable. He is patch that >> fixed it + code for detecting svn revision (MYSVN_WC_REVISION) from git >> >>>>>>>> >> >>>>>>>> [1] >> https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize= -code?view=3Dmsvc-160 >> >>>>>>>> >> >>>>>>>> Zdenko >> >>>>>>>> >> >>>>>>>> _______________________________________________ >> >>>>>>>> sword-devel mailing list: [email protected] >> >>>>>>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>>>>>> Instructions to unsubscribe/change your settings at above page >> >>>>>>> >> >>>>>>> _______________________________________________ >> >>>>>>> sword-devel mailing list: [email protected] >> >>>>>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>>>>> Instructions to unsubscribe/change your settings at above page >> >>>>>> >> >>>>>> _______________________________________________ >> >>>>>> sword-devel mailing list: [email protected] >> >>>>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>>>> Instructions to unsubscribe/change your settings at above page >> >>>>> >> >>>>> _______________________________________________ >> >>>>> sword-devel mailing list: [email protected] >> >>>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>>> Instructions to unsubscribe/change your settings at above page >> >>>> >> >>>> _______________________________________________ >> >>>> sword-devel mailing list: [email protected] >> >>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>> Instructions to unsubscribe/change your settings at above page >> >>>> >> >>>> _______________________________________________ >> >>>> sword-devel mailing list: [email protected] >> >>>> http://crosswire.org/mailman/listinfo/sword-devel >> >>>> Instructions to unsubscribe/change your settings at above page >> >>> >> >>> _______________________________________________ >> >>> sword-devel mailing list: [email protected] >> >>> http://crosswire.org/mailman/listinfo/sword-devel >> >>> Instructions to unsubscribe/change your settings at above page >> >> >> >> _______________________________________________ >> >> sword-devel mailing list: [email protected] >> >> http://crosswire.org/mailman/listinfo/sword-devel >> >> Instructions to unsubscribe/change your settings at above page >> > >> > _______________________________________________ >> > sword-devel mailing list: [email protected] >> > http://crosswire.org/mailman/listinfo/sword-devel >> > Instructions to unsubscribe/change your settings at above page >> _______________________________________________ >> sword-devel mailing list: [email protected] >> http://crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page >> > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > --000000000000913961063cc58eba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>My personal aim is to build the sword on windows with= msvc and/or clang. So autotools is not an option=C2=A0(compared=C2=A0to li= nux).</div><div>I have several years experience with cmake and building c++= multiplatform projects, so I can help with this.</div><div>I believe bring= ing the sword to "msvc=C2=A0 (and git ;-) ) world" could bring another contributor to this project.= </div><div><br></div><div>=C2=A0 Zdenko</div></div><br><div class=3D"gmail_= quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, = 20 Aug 2025 at 05:55, Greg Hellings <<a href=3D"mailto:greg.hellings@gma= il.com">[email protected]</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"><div dir=3D"auto"><div><br><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Aug 19, 2025= , 10:34=E2=80=AFPM Aaron Rainbolt <<a href=3D"mailto:[email protected]= m" target=3D"_blank">[email protected]</a>> wrote:<br></div><blockquo= te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex">FWIW (and as you well know since y= ou're still a co-maintainer of it),<br> the SWORD package for Fedora relies on the CMake toolchain.<br></blockquote= ></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Indeed. But it r= eally shouldn't. Mea culpa on that! The main reason I never switched it= is because it is the only currently easy access I have to the bindings wit= hout always needing to stand up a development environment everywhere.=C2=A0= </div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quo= te"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor= der-left:1px solid rgb(204,204,204);padding-left:1ex"> Personally, I've always used CMake rather than autotools for building<b= r> SWORD when doing custom builds of it. I was under the impression that<br> the autotools toolchain was deprecated.<br></blockquote></div></div><div di= r=3D"auto"><br></div><div dir=3D"auto">No. Autotools is the source of truth= . CMake is a "best effort" alternative that started out really as= just a way for me to enable Python bindings and Windows builds. But now au= totools supports Windows (cross-build) targets just as readily as it does U= nix targets. And people who want to use Python or Perl are well served by t= he existing CMake toolchain.</div><div dir=3D"auto"><br></div><div dir=3D"a= uto">Ideally the bindings should be pulled out to a separate package and up= loaded to, for example, PyPI. (Peter - do you still use the Perl bindings? = I think you might have been the only one to ever use those, but do you stil= l?) That way they are available through that language's native tooling.= I did that, once upon a time, but adding tooling to automatically regenera= te the Swig binding would take that a long way.=C2=A0</div><div dir=3D"auto= "><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"> <br> As for why one would use CMake instead, you could probably quote<br> whatever the usual arguments are for using CMake instead of autotools<br></= blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I'= ve never actually seen such a debate. Despite having no qualms with shell s= cript, I still find CMake more legible. But autotools is well known and rea= dily supported almost anywhere. Except for Windows build hosts. And early o= n I was hoping to provide a way to build with MSVC through it to replace th= e old handcrafted Windows build scripts. But when MinGW had fully matured, = that need was eliminated.=C2=A0</div><div dir=3D"auto"><br></div><div dir= =3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" styl= e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin= g-left:1ex"> (easier to audit for security as opposed to autogenerated<br> multi-thousand-line-long shell scripts written in convoluted<br> antediluvian POSIX sh language designed to work on older versions of<br> Solaris and that check for bugs existing in assorted other ancient and<br> likely entirely unused flavors of UNIX among other things, you don't<br= > have to build the build system itself and potentially run into<br> insurmountable issues in so doing if trying to build SWORD on a system<br> older or newer than the ones upstream uses, modifying the build system<br> to add extra source files or move things around only gives one a<br> migraine rather than making their head explode, etc.). I personally<br> would like to not have to change the Fedora SWORD package from using<br> CMake, and would ask for help if the CMake side of things broke<br> because I don't want to fight with autoheadache.<br></blockquote></div>= </div><div dir=3D"auto"><br></div><div dir=3D"auto">The problem is, those a= ntique targets are still actively supported by Sword, so using autotools is= still a really good choice. Personally I don't even dabble in C these = days unless I need to edit someone else's code. But more modern languag= es don't really target those older systems, so autotools for a C++ code= base is pretty much the best thing going to service all of breadth of syst= ems that Sword supports.</div><div dir=3D"auto"><br></div><div dir=3D"auto"= >--Greg</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gm= ail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.= 8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> On Tue, Aug 19, 2025 at 10:22=E2=80=AFPM Greg Hellings <<a href=3D"mailt= o:[email protected]" rel=3D"noreferrer" target=3D"_blank">greg.hellin= [email protected]</a>> wrote:<br> ><br> > What are your needs for using the CMake toolchain? It is strictly infe= rior to the autotools system with the exception of supporting Python and Pe= rl more robustly. But I never was able to get it handling all of the Unicod= e tests perfectly, and even I don't use it anymore for the places where= I maintain Sword builds. The two initial reasons for putting it together w= ere MinGW support which was superior at that time in CMake than autotools (= this is no longer the case) and the Python/Perl bindings. But even those I = would likely move over to autotools at this point when the need for an upda= te appears.<br> ><br> > --Greg<br> ><br> > On Mon, Aug 18, 2025, 4:25=E2=80=AFAM ZdPo Ster <<a href=3D"mailto:= [email protected]" rel=3D"noreferrer" target=3D"_blank">[email protected]= </a>> wrote:<br> >><br> >> Any idea when cmake build will be fixed & improved?<br> >> Recent svn version can not be built with cmake. Minimum change to = at least finish configure requires:<br> >><br> >> diff --git a/CMakeLists.txt b/CMakeLists.txt<br> >> index 676353b5..bd3e6f81 100644<br> >> --- a/CMakeLists.txt<br> >> +++ b/CMakeLists.txt<br> >> @@ -11,13 +11,14 @@<br> >>=C2=A0 # of their own GPLv2 license and all copyright is transferre= d to them for<br> >>=C2=A0 # all posterity and eternity, wherever such transfer is poss= ible.=C2=A0 Where it is<br> >>=C2=A0 # not, then this file is released under the GPLv2 by myself.= <br> >> +CMAKE_MINIMUM_REQUIRED(VERSION 3.10.0)<br> >><br> >>=C2=A0 CMAKE_POLICY(SET CMP0010 NEW)<br> >>=C2=A0 include(FindSubversion)<br> >>=C2=A0 Subversion_WC_INFO(${CMAKE_CURRENT_SOURCE_DIR} MYSVN IGNORE_= SVN_FAILURE)<br> >><br> >>=C2=A0 PROJECT(libsword CXX C)<br> >> -CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0)<br> >> +<br> >>=C2=A0 SET(SWORD_VERSION 1.9.0)<br> >>=C2=A0 if(DEFINED MYSVN_WC_REVISION)<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SET(SWORD_VERSION ${SWORD_VERSION= }.${MYSVN_WC_REVISION})<br> >><br> >> --Zdenko<br> >><br> >> On Fri, 17 Mar 2023 at 19:25, Greg Hellings <<a href=3D"mailto:= [email protected]" rel=3D"noreferrer" target=3D"_blank">greg.hellings= @gmail.com</a>> wrote:<br> >>><br> >>> Indeed. It's not a principled stand that I'm refusing = to get Subversion going. It's simply that it's too much work that I= haven't bothered and don't foresee doing so anytime soon.<br> >>><br> >>> And, with no setup to automatically test the scripts in all th= e environments they must support, it's not likely others are willing to= commit this on my behalf.<br> >>><br> >>> --Greg<br> >>><br> >>> On Sun, Mar 12, 2023, 09:42 Peter von Kaehne <<a href=3D"ma= ilto:[email protected]" rel=3D"noreferrer" target=3D"_blank">[email protected]</a= >> wrote:<br> >>>><br> >>>> I think you misunderstood Greg.<br> >>>><br> >>>> There is a long campaign and strong feeling to have the pr= oject on Git but there is no agreement or movement to that. And it seems Gr= eg is pausing his contributions until that matter is resolved.<br> >>>><br> >>>> Peter<br> >>>><br> >>>> Sent from my phone. Please forgive misspellings and weird = =E2=80=9Ccorrections=E2=80=9D<br> >>>><br> >>>> On 12 Mar 2023, at 15:51, ZdPo Ster <<a href=3D"mailto:= [email protected]" rel=3D"noreferrer" target=3D"_blank">[email protected]= </a>> wrote:<br> >>>><br> >>>> =EF=BB=BF<br> >>>> I am sorry, but I did not get the point of your reply.<br> >>>> I do not use subversion - I use git-svn as proposed severa= l months ago on this forum. But current cmake configuration expects everybo= dy to use subversion, which is wrong.<br> >>>> These patches improve cmake build:<br> >>>><br> >>>>=C2=A0 that will work also with git-svn<br> >>>> MSVC build<br> >>>> fix depreciated<br> >>>><br> >>>> AFAIK it should cause no harm for other combinations, just= improve current state.<br> >>>><br> >>>> Zdenko<br> >>>><br> >>>> On Thu, 9 Mar 2023 at 23:18, Greg Hellings <<a href=3D"= mailto:[email protected]" rel=3D"noreferrer" target=3D"_blank">greg.h= [email protected]</a>> wrote:<br> >>>>><br> >>>>> I've never bothered to get Subversion setup on my = local machine. Remembering the setup, plus my credentials, and how to use i= t is more labor than I've been willing to spend on this effort. If, in = the future, I overcome that inertia then I'll happily test and apply th= is patch.<br> >>>>><br> >>>>> --Greg<br> >>>>><br> >>>>> On Sat, Feb 25, 2023 at 5:34 AM ZdPo Ster <<a href= =3D"mailto:[email protected]" rel=3D"noreferrer" target=3D"_blank">zdposte= [email protected]</a>> wrote:<br> >>>>>><br> >>>>>> Any update on this (after 3.5 months)?<br> >>>>>><br> >>>>>> Zdenko<br> >>>>>><br> >>>>>> On Sat, 26 Nov 2022 at 21:53, Greg Hellings <<a= href=3D"mailto:[email protected]" rel=3D"noreferrer" target=3D"_blan= k">[email protected]</a>> wrote:<br> >>>>>>><br> >>>>>>> Thanks. I am not privy to the patches email in= box, so this mailing list is the way to reach me for CMake things. I'll= review these when I have the opportunity.<br> >>>>>>><br> >>>>>>> --Greg<br> >>>>>>><br> >>>>>>> On Sat, Nov 26, 2022, 13:46 Peter von Kaehne &= lt;<a href=3D"mailto:[email protected]" rel=3D"noreferrer" target=3D"_blank">r= [email protected]</a>> wrote:<br> >>>>>>>><br> >>>>>>>><br> >>>>>>>> How to suggest improvements to the sword p= roject?<br> >>>>>>>><br> >>>>>>>><br> >>>>>>>><br> >>>>>>>> You did it the right way. It just is a bit= on/off as a project. GHellings is the cmake pumpkin holder as far as I kno= w. I bcc him on a different email address.<br> >>>>>>>><br> >>>>>>>> Peter<br> >>>>>>>><br> >>>>>>>><br> >>>>>>>><br> >>>>>>>> BR,<br> >>>>>>>><br> >>>>>>>> Zdenko<br> >>>>>>>><br> >>>>>>>> ---------- Forwarded message ---------<br> >>>>>>>> From: ZdPo Ster <<a href=3D"mailto:zdpo= [email protected]" rel=3D"noreferrer" target=3D"_blank">[email protected]</a>= ><br> >>>>>>>> Date: Sun, 6 Nov 2022 at 22:22<br> >>>>>>>> Subject: cmake patches<br> >>>>>>>> To: <<a href=3D"mailto:patches@crosswir= e.org" rel=3D"noreferrer" target=3D"_blank">[email protected]</a>><b= r> >>>>>>>><br> >>>>>>>><br> >>>>>>>> Hello,<br> >>>>>>>><br> >>>>>>>> please find 3 few patches related to cmake= build (tested on windows with MSVC 2019):<br> >>>>>>>><br> >>>>>>>> cmake_fix_deprecation.patch - cmake versio= n 3.23.2 produce depreciation warning for old minimum version, co IMO it is= time to increase expected cmake version<br> >>>>>>>> cmake_fix_msvc.patch - there is no "/= O3" options in current MSVC[1]<br> >>>>>>>> cmake_git_svn.patch - I use git svn for ac= cessing code, but cmake produce error because of missing svn executable. He= is patch that fixed it + code for detecting svn revision (MYSVN_WC_REVISIO= N) from git<br> >>>>>>>><br> >>>>>>>> [1] <a href=3D"https://learn.microsoft.com= /en-us/cpp/build/reference/o-options-optimize-code?view=3Dmsvc-160" rel=3D"= noreferrer noreferrer" target=3D"_blank">https://learn.microsoft.com/en-us/= cpp/build/reference/o-options-optimize-code?view=3Dmsvc-160</a><br> >>>>>>>><br> >>>>>>>> Zdenko<br> >>>>>>>><br> >>>>>>>> __________________________________________= _____<br> >>>>>>>> sword-devel mailing list: <a href=3D"mailt= o:[email protected]" rel=3D"noreferrer" target=3D"_blank">sword-dev= [email protected]</a><br> >>>>>>>> <a href=3D"http://crosswire.org/mailman/li= stinfo/sword-devel" rel=3D"noreferrer noreferrer" target=3D"_blank">http://= crosswire.org/mailman/listinfo/sword-devel</a><br> >>>>>>>> Instructions to unsubscribe/change your se= ttings at above page<br> >>>>>>><br> >>>>>>> ______________________________________________= _<br> >>>>>>> sword-devel mailing list: <a href=3D"mailto:sw= [email protected]" rel=3D"noreferrer" target=3D"_blank">sword-devel@c= rosswire.org</a><br> >>>>>>> <a href=3D"http://crosswire.org/mailman/listin= fo/sword-devel" rel=3D"noreferrer noreferrer" target=3D"_blank">http://cros= swire.org/mailman/listinfo/sword-devel</a><br> >>>>>>> Instructions to unsubscribe/change your settin= gs at above page<br> >>>>>><br> >>>>>> _______________________________________________<br= > >>>>>> sword-devel mailing list: <a href=3D"mailto:sword-= [email protected]" rel=3D"noreferrer" target=3D"_blank">sword-devel@cross= wire.org</a><br> >>>>>> <a href=3D"http://crosswire.org/mailman/listinfo/s= word-devel" rel=3D"noreferrer noreferrer" target=3D"_blank">http://crosswir= e.org/mailman/listinfo/sword-devel</a><br> >>>>>> Instructions to unsubscribe/change your settings a= t above page<br> >>>>><br> >>>>> _______________________________________________<br> >>>>> sword-devel mailing list: <a href=3D"mailto:sword-deve= [email protected]" rel=3D"noreferrer" target=3D"_blank">sword-devel@crosswire= .org</a><br> >>>>> <a href=3D"http://crosswire.org/mailman/listinfo/sword= -devel" rel=3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.or= g/mailman/listinfo/sword-devel</a><br> >>>>> Instructions to unsubscribe/change your settings at ab= ove page<br> >>>><br> >>>> _______________________________________________<br> >>>> sword-devel mailing list: <a href=3D"mailto:sword-devel@cr= osswire.org" rel=3D"noreferrer" target=3D"_blank">[email protected]= </a><br> >>>> <a href=3D"http://crosswire.org/mailman/listinfo/sword-dev= el" rel=3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.org/ma= ilman/listinfo/sword-devel</a><br> >>>> Instructions to unsubscribe/change your settings at above = page<br> >>>><br> >>>> _______________________________________________<br> >>>> sword-devel mailing list: <a href=3D"mailto:sword-devel@cr= osswire.org" rel=3D"noreferrer" target=3D"_blank">[email protected]= </a><br> >>>> <a href=3D"http://crosswire.org/mailman/listinfo/sword-dev= el" rel=3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.org/ma= ilman/listinfo/sword-devel</a><br> >>>> Instructions to unsubscribe/change your settings at above = page<br> >>><br> >>> _______________________________________________<br> >>> sword-devel mailing list: <a href=3D"mailto:sword-devel@crossw= ire.org" rel=3D"noreferrer" target=3D"_blank">[email protected]</a>= <br> >>> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" = rel=3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailma= n/listinfo/sword-devel</a><br> >>> Instructions to unsubscribe/change your settings at above page= <br> >><br> >> _______________________________________________<br> >> sword-devel mailing list: <a href=3D"mailto:sword-devel@crosswire.= org" rel=3D"noreferrer" target=3D"_blank">[email protected]</a><br> >> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel= =3D"noreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/l= istinfo/sword-devel</a><br> >> Instructions to unsubscribe/change your settings at above page<br> ><br> > _______________________________________________<br> > sword-devel mailing list: <a href=3D"mailto:[email protected]"= rel=3D"noreferrer" target=3D"_blank">[email protected]</a><br> > <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"n= oreferrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/listin= fo/sword-devel</a><br> > Instructions to unsubscribe/change your settings at above page<br> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" rel= =3D"noreferrer" target=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer noreferrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sw= ord-devel</a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div></div></div> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" targ= et=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-devel</= a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> --000000000000913961063cc58eba-- --===============6272776381193088983== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sword-devel mailing list: [email protected] http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page --===============6272776381193088983==--