Re: Patch- HTML update +misc fixes
Mike Tremaine <[email protected]>
| Newsgroups | gmane.comp.log.logwatch.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sep 17, 2007, at 3:01 AM, Ross Becker wrote:
> Okay,
> Here's my first patch. It's against the current CVS code.
>
>
> Fixups:
> - I updated the HTML output to be a little easier on the eyes. This
> still could use a bunch more work, but it's significantly better
> (subjectively to me) than it was. Various changes ranging from
> font/color/table formatting to removing the "section begin" and
> "section
> end" outputs, since the HTML table clearly delineates the service
> beginnings and ends.
> - The case of HTML output with splithost on and multiemail off was
> broken; The "Reporting on hosts:" line would be emitted before the
> MIME
> type and the HTML, completely breaking some HTML renderers. I
> moved the
> output of that to go under the "Logwatch summary" section.
> - In the case of splithost on and multiemail off, the hostname used
> for the summary was not the host that logwatch was run on; it would
> pick
> up one of the hosts for which it processed logfiles and use that.
> Fixed
> the email subject to use ${hostname} instead of $config{'hostname'}
> which was subject to change.
>
The patch against header.html has been committed to CVS. [boy did
that take a long time :P ]
THe patch against logwatch.pl has not been applied, I need to test a
little because of all the other changes in the mail script.
-Mike