Re: 9 Debian patches for inclusion

Am Sonntag, 15. Januar 2012, 11:02:48 schrieb Willi Mann:
> Hi!
> 
> Could anyone please take a look at the patches I'm including in the Debian
> package and include them in the SVN repository, please? I'd like to avoid
> diverting too much from the official sources.
> 
> The patches I'm currently including are listed at
> 
> http://patch-tracker.debian.org/package/logwatch/7.4.0+svn20111221rev79-1
> 
> (The first one should not be included. To avoid the patch, we could control
> this by a configuration option.)

0001: rejected - Debian specific
0002: rejected - I don't think this is the proper way to address the problem. 
Maybe Mike (mgt) knows a better solution.
0003: accepted
0004: accepted
0005: accepted
0006: rejected - old amavis script
0007: accepted
0008: accepted
0009: I have a problem with this change:
-*OnlyService = (kernel:)?\s*(\[\s*\d+\.\d+\]\s*)?(type=[0-9]+\s*)?audit.*
+*OnlyService = (kernel:( \[[ 0-9\.]+\])?)?\s*(type=[0-9]+\s*)?audit.*
Can you assure that it doesn't break backwards compatibility?
0010: And again this seams to break backwards compatibility, too:
-     $ThisLine =~ s/^\w{3} .\d \d\d:\d\d:\d\d [^ ]* //;
+     $ThisLine =~ s/^\w{3} .\d \d\d:\d\d:\d\d //;

Maybe someone can comment in more detail why the changes (0009, 0010) are 
necessary.

> thanks
> WM

Thanks
Stefan

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2