Re: Fedora patches for 7.4.1

Jan Synacek <[email protected]> Tue, 14 Oct 2014 09:24:22 +0200
Newsgroups gmane.comp.log.logwatch.devel
Message-ID <[email protected]>
Orion Poplawski <[email protected]> writes:
> On 09/24/2014 01:20 AM, Jan Synacek wrote:
>> Hello list,
>>
>> please, consider merging the following fedora patches:
>>
>> * xntpd [1]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-xntpd.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> Applied the updated version
>>
>> * vstfpd [2]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-vsftpd.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> This doesn't seem right - hard-coding vsftpd into logwatch.pl.  Should be set 
> in ./conf/logfiles/vsftpd.conf, right?

Makes sense.

>> * secure usernames [3]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-secure-username.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> Applied.
>>
>> * secure userhelper [4]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-secure-userhelper.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> Personally, I would rather see the full execution line printed.  That would 
> match up with counts better too.

Makes sense.

>>
>> * rootkit hunter support [5]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-rkhunter.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> applied
>
>> * --no-oldfiles-log support [6]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-oldfiles.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> Perhaps a --silent or --quiet option makes more sense?

--quiet sounds good.

>>
>> * dnssec messages [7]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-named-dnssec.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>
> applied
>>
>> * updated dovecot parsing [8]
>>    http://pkgs.fedoraproject.org/cgit/logwatch.git/tree/logwatch-dovecot.patch?id=4b0721431fff01101fb0f2a634057e237476ab8f
>>
>
> Applied.
>

I'm sorry for such late response. I currently don't have much time to
rework and test the [2], [4] and [6], so feel free to rewrite them.

Cheers,
-- 
Jan Synacek
Software Engineer, Red Hat

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho