Re: [logwatch:git] Merge request: rhel 8 patches, 7.5.x branch (7.5.1)

> -----Original Message-----
> From: Bjorn via Logwatch-devel 
> Sent: Sunday, January 13, 2019 2:29 PM
> 
> Jason,
> 
> 
> Here is what I had mentioned to Jan regarding the four bugs you listed:
> 
> #1317620
> 	logwatch-sshd-2.patch
> 	Some of the changes were previously patched (regarding
> 	disconnect).  Applied the change regarding exiting statement.

I will compare the messages covered by sshd on master and the 1317620
branch, will follow up then.

> 
> #1326808
> 	logwatch-postfix.patch
> 	It appears that the scripts were already modified, although
> 	with spacing slightly different from that on your patch.

I deferred to the most analysis done on the differing format widths.

The RH patch, said it found the longest string and added a fixed constant to
come up with the padding value, the Debian patch never defined why they
selected a smaller padding width.


> 
> #217226
> 	logwatch-vsftpd.patch
> 	Not sure if this is still applicable, and fix was applied
> 	incorrectly.  Each script has its own configuration file,
> 	and that's were the change, if needed, should occur.  The
> 	vsftpd configuration does call the applystddate script.


I will take a stab at making 217226 better (more aligned to the logwatch
way) and opening a new ticket on Bugzilla.redhat.com.

> 
> #230974
> 	logwatch-oldfiles.patch
> 	Seems to me that the warning message was not interpreted
> 	correctly.  The proper solution was to delete the
> 	directories mentioned.
> 

With regards to bug 230974, the tmpdir is cleared on reboot for some
systems. This option makes sense for those platforms.

> 
> 
> For the other bugs (either closed with patches, or in "new" status), I
> believe that either previous patches solved it, or I incorporated the
> proposed patch.

I can confirm that all the other patches for EL8 are already in master.

> 
> 
> 
> On 1/13/19 10:43 AM, Jason Pyeron wrote:
> > Good to know, let me cancel the merge request.
> >
> >
> >
> > I did my best to track the el8 patches against the master branch, there
> > are the deltas remaining in EL8's logwatch, I will grab the latest
> > Fedora version soon:
> >
> >
> >
> > bb7a22 - Red Hat bug #1317620
> >
> > 5034ca - Red Hat bug #1326808
> >
> > a47473 - Red Hat bug #217226
> >
> > a18283 - Red Hat bug #230974
> >
> >
> >
> > I would like to read up on the past issues, can you point me to the
> > discussions - I did search extensively before making the el8 branch.
> > (https://sourceforge.net/u/jpyeron/logwatch/ci/logwatch-el8/)
> >
> >
> >
> > -Jason
> >
> >
> >
> > *From:*Bjorn <[email protected]>
> > *Sent:* Sunday, January 13, 2019 1:31 PM
> > *To:* [logwatch:git] <[email protected]>
> > *Subject:* [logwatch:git] Merge request: rhel 8 patches, 7.5.x branch
> > (7.5.1)
> >
> >
> >
> > This is all a bit confusing. The 7.5.0 was created from the 'master'
> > branch on 12/28/18. The next release, 7.5.1, will be created from the
> > master branch in the (very near) future.
> > We don't want to create the 7.5.1 from the RH/Fedora release, which is
> > what this merge request seems to do. In my opinion, some of the patches
> > in RH/Fedora are incorrect, and I had communicated with Jan Synacek on
> > how they should be resolved. I am hoping that the next RH/Fedora
> > logwatch would be based on a tagged release from here; most likely the
> > 7.5.1.