Re: We need to stop lower casing everything!

Bjorn via Logwatch-devel <[email protected]> Tue, 20 Oct 2020 13:10:37 -0700
Newsgroups gmane.comp.log.logwatch.devel
Message-ID <[email protected]>
I am pretty sure it was well before that 2006 date.  I assumed it was a
decision from the initial creation of logwatch, well before my (and
probably your) initial involvement.

Indeed, the main stumbling blocks are backwards compatibility (minimize
breaking existing logwatch deployments), and testing.  We don't have a
test suite, and most servers probably exercise only a small fraction of
the overall logwatch code base.

Of the list of files you sent, the services have the most occurrences of
'lc', but I believe that the configuration files (both default and
user-defined) are where the most problems would occur.  Because most
declared names and values are lower-cased when read by logwatch.


On 10/20/20 11:38 AM, Mike Tremaine wrote:
> I think.. It happened back around 2006 on move from 7.0 to 7.1
> 
> I see this email exchange in my folder
> 
>> On Tue, 2006-01-17 at 22:41 -0500, Aaron Weeks wrote:
>>
>>>
>>>> Also, I've noticed in the 7.1 and 7.2 releases, that at some point, 
>>>> logfiles will get changed to lowercase.  I am trying to write a filter 
>>>> for oracle, and my oracle alert logs have uppercase letters in the 
>>>> paths.  Is the shifting to lowercase intentional?  If so, is there a 
>>>> way around it?
>>>
>>> This problem is still an issue.  When the logfile name gets shifted to 
>>> lowercase, it sees my log file as not existing.
>>>
>>
>> Use quotes around your log file names
>>
>> LogFile = "NAME"
>>
>> Otherwise everything gets lowercased.
>>
>> -Mike
>>
>> [We should put that in the HOWTO ;) ]
> 
> 
> I also see some early issues with the HTTP module and the Exploits file. I do not remember doing this so I doubt I added the lowercase code but it was a long time ago. I think it can be removed BUT there would have to be a lot testing to see what breaks when you do it. Just my 2 cent opinion.
> 
> -Mike
> 
> 
>> On Oct 20, 2020, at 11:27 AM, Orion Poplawski <[email protected]> wrote:
>>
>> Folks -
>>
>>  It's becoming past ridiculous that logwatch lowercases everything in the
>> configuration files.  I'm afraid I never understood the reason for it.
>> Perhaps someone with a longer experience with logwatch can tell me?
>>
>>  But the latest issue is with sudo's ignore_commands - and this is important
>> since different cased commands could conceivably be quite different.
>>
>>  So, what are the ramifications of no longer lower-casing everything?
>>
>> Orion
>>
>> -- 
>> Orion Poplawski
>> Manager of NWRA Technical Systems          720-772-5637
>> NWRA, Boulder/CoRA Office             FAX: 303-415-9702
>> 3380 Mitchell Lane                       [email protected]
>> Boulder, CO 80301                 https://www.nwra.com/
>>
>>
>> _______________________________________________
>> Logwatch-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/logwatch-devel
> 
> 
> 
> _______________________________________________
> Logwatch-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/logwatch-devel
>