Re: [mh] Git woes

Lieven Hollevoet <[email protected]> Sun, 24 Jan 2021 11:07:03 +0100
Newsgroups	gmane.comp.misc.misterhouse.user
Message-ID	<[email protected]>
Hey Giles,

thanks for taking the effort to contribute code!

The reason you get the error: you are trying to commit to the main repo instead of your own.

The reason why this is not possible: for code contributions there is a review process in place that requires contributors to submit a pull request to the main repo instead of performing a direct commit.
The rationale behind this principle are the following 2 advantages:
* it allows to run automatic regression tests on your proposed change, that do basic sanity checks telling us the change does not break something fundamental
* it allows other people to review the proposed change before actually adding it to the ‘main’ repository.

To fix your issue please doublecheck https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors <https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors>, specifically the first three bullets. You omitted them as I can see in your snipped, and that is why the process fails.

Best regards,
 Lieven.


> Op 23 jan. 2021, om 11:49 heeft Giles Godart-Brown <[email protected]> het volgende geschreven:
> 
> I've been trying to re-add the example 'occupied_mode_demo.pl' following the steps in the git wiki, but it fails.  Can someone please help so I can fix the wiki;
> 
> <snip>
> 
> git clone git://github.com/hollie/misterhouse.git
> cd misterhouse
> git checkout master
> git checkout -b re_adding_occupied_mode_demo
> 
> # copied the old example into code/examples
> 
> git stage code/examples/occupied_mode_demo.pl
> git status
> On branch re_adding_occupied_mode_demo
> Changes to be committed:
>   (use "git reset HEAD <file>..." to unstage)
> 
>     new file:   code/examples/occupied_mode_demo.pl
> 
> git add code/examples/occupied_mode_demo.pl
> git commit -m "Re adding occupied_mode_demo.pl"
> [re_adding_occupied_mode_demo 2ab4b274] Re adding occupied_mode_demo.pl
>  1 file changed, 119 insertions(+)
>  create mode 100644 code/examples/occupied_mode_demo.pl
> 
>  git push origin re_adding_occupied_mode_demo
> fatal: remote error:
>   You can't push to git://github.com/hollie/misterhouse.git
>   Use https://github.com/hollie/misterhouse.git <https://github.com/hollie/misterhouse.git>
> </snip>
> 
> Thanks
> 
> Giles
> 
> ________________________________________________________
> To unsubscribe from this list, go to: https://lists.sourceforge.net/lists/listinfo/misterhouse-users
>

________________________________________________________
To unsubscribe from this list, go to: https://lists.sourceforge.net/lists/listinfo/misterhouse-users
signature.asc (application/pgp-signature, 833 B)