Re: [mh] Is this the expected behaviour of process_item?

=head1 B<Process_Item_queue>

=head2 SYNOPSIS

  
=head2 DESCRIPTION

use this object to add process items to a queue. 
This version has a single queue called @process_item_queue, the next item on the queue is forked when the previous one finishes

=head2 INHERITS

<>

=head2 METHODS

add_to_queue add a process item to the queue
check_process_item_queue This is called regularly to see if it has any items to process on the queue

=over

=cut

use strict;
use Data::Dumper;

#-----------------------------------------------------------------------
# tests
#-----------------------------------------------------------------------
# noloop=start
$my_test1   = new Voice_Cmd 'Run test [1,2,3,4]';
$p_longproc = new Process_Item;
set $p_longproc $config_parms{"code_dir"} . "/procs/longproc.sh";
$p_longproc->set_output( $config_parms{data_dir} . "/logs/longproc.txt" );
$p_longproc->set_timeout(10);

# noloop=stop

if ( $state = said $my_test1) {
	if ( $state == 1 ) {
		add_process_item_to_queue("p_longproc");
		check_process_item_queue();
	}
	elsif ( $state == 2 ) {
		print_log( "Longproc run 1", "INFORMATIONAL", "p_longproc" );
		add_process_item_to_queue("p_longproc");
		print_log( "Longproc run 2", "INFORMATIONAL", "p_longproc" );
		add_process_item_to_queue("p_longproc");

	}

	elsif ( $state == 3 ) {

	}
	elsif ( $state == 4 ) {

	}
}

if ( done_now $p_longproc) {
	print_log( "Longproc done", "INFORMATIONAL", "p_longproc" );
	if ( timed_out $p_longproc) {
		print_log( 'longproc - timed out', "ERROR", "p_longproc" );
	}
	print_process_log( "longproc.txt", "p_longproc" );
}

#-----------------------------------------------------------------------
# every  seconds check the queue
#-----------------------------------------------------------------------

if ($New_Second) {
	check_process_item_queue();
}

#-----------------------------------------------------------------------
# globals
#-----------------------------------------------------------------------

#-----------------------------------------------------------------------
# Add a process item to the queue
#-----------------------------------------------------------------------

sub add_process_item_to_queue {
	my $this_process = $_[0];
	print_log( "Adding " . $this_process . " to the queue",
		"INFORMATIONAL", "add_process_item_to_queue" );
	if ( scalar @process_item_queue == 0 ) {
		start_process_name($this_process);
	}

	push @process_item_queue, $this_process;

}

#-----------------------------------------------------------------------
# check the process_item_queue
# if the previous one is done, delete it and action the next
#-----------------------------------------------------------------------
sub check_process_item_queue {
	my ( $this_process, $next_process );
	my $count_items_in_queue = scalar @process_item_queue;
	if ( $count_items_in_queue > 0 ) {
		print_log(
			"there are  " . $count_items_in_queue . " items in the queue",
			"INFORMATIONAL", "check_process_item_queue" );
		$this_process = @process_item_queue[0];
		my $this_process_object = get_object_by_name($this_process);
		if ( !defined( $this_process_object->{done} ) )
		{    # this process is still running
			return;
		}
		else {
			print_log( $this_process . " has finished",
				"INFORMATIONAL", "check_process_item_queue" );
			if ( $count_items_in_queue == 1 ) {
				@process_item_queue = ();
			}
			else {

				$next_process = shift @process_item_queue;
				print_log( "Starting process item " . $next_process,
					"INFORMATIONAL", "check_process_item_queue" );
				start_process_name($this_process);
			}
		}
		return;
	}
	else {
		return;
		print_log( "Process_item_queue is empty",
			"INFORMATIONAL", "check_process_item_queue" );
	}

}

#-----------------------------------------------------------------------
# start a process given its name
#-----------------------------------------------------------------------
sub start_process_name {
	my $this_process = $_[0];
	my $command      = "start \$" . $this_process . ";";
	print_log( "running " . $command, "INFORMATIONAL", "start_process_name" );
	eval $command;
	return;
}
########################################################################
# History:
# 19-02-2021 new code