Re: [mh] Small typo in Tasmota_HTTP_Item.pm
Giles Godart-Brown <[email protected]> Fri, 15 Dec 2023 10:57:58 +0000
| Newsgroups | gmane.comp.misc.misterhouse.user |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--===============5308220887805073224==
Content-Type: multipart/alternative;
boundary="------------fWgcLyQ8v00L06ahQpEBTlWG"
Content-Language: en-GB
This is a multi-part message in MIME format.
--------------fWgcLyQ8v00L06ahQpEBTlWG
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
I also noticed that it changes the set_by value to 'process item' if you
use the async mode. I got around this by adding
$self->{this_set_by} = $set_by;
at the beginning of the set subroutine
and
in process_check changing
#$self->SUPER::set( $state, "process item") unless (lc
$state eq lc $self->state());
to
$self->SUPER::set( $state, $self->{this_set_by}) unless (lc $state eq lc
$self->state());
I'll create an issue so both these can be picked up during the next release
Giles
On 11/12/2023 20:11, Giles Godart-Brown wrote:
> All
> I've just updated my MH installation to the latest Master release and
> while experimenting with the async mode and Tasmota I noticed there is
> a small typo on line 203 of Tasmota_HTTP_Item.pm
> it should read
> $self->send_cmd($cmd);
> and not
> $self->send_cmnd($cmd);
> Regards
> Giles
--------------fWgcLyQ8v00L06ahQpEBTlWG
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<font size="5" face="Calibri">I also noticed that it changes the
set_by value to 'process item' if you use the async mode. I got
around this by adding <br>
$self->{this_set_by} = $set_by;<br>
<br>
at the beginning of the set subroutine<br>
<br>
and <br>
in process_check changing<br>
#$self->SUPER::set( $state, "process item")
unless (lc $state eq lc $self->state());<br>
to<br>
</font><font size="5" face="Calibri">
$self->SUPER::set( $state, $self->{this_set_by}) unless (lc
$state eq lc $self->state());<br>
<br>
I'll create an issue so both these can be picked up during the
next release<br>
<br>
Giles</font><br>
<br>
<div class="moz-cite-prefix">On 11/12/2023 20:11, Giles Godart-Brown
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:[email protected]">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<font size="4" face="Calibri">All<br>
I've just updated my MH installation to the latest Master
release and while experimenting with the async mode and Tasmota
I noticed there is a small typo on line 203 of
Tasmota_HTTP_Item.pm<br>
it should read <br>
</font><font size="4" face="Calibri"> $self->send_cmd($cmd); <br>
and not<br>
</font><font size="4" face="Calibri">$self->send_cmnd($cmd);
<br>
Regards<br>
Giles <br>
</font> </blockquote>
<br>
</body>
</html>
--------------fWgcLyQ8v00L06ahQpEBTlWG--
--===============5308220887805073224==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============5308220887805073224==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
________________________________________________________
To unsubscribe from this list, go to: https://lists.sourceforge.net/lists/listinfo/misterhouse-users
--===============5308220887805073224==--