Re: Bug in gpape's ipsvd

Gerrit Pape <[email protected]>
Newsgroups gmane.comp.sysutils.supervision.general,gmane.comp.misc.pape.general
Message-ID <[email protected]>
On Sun, Jul 04, 2004 at 07:08:44PM +0100, Torne wrote:
> tcpsvd interprets an instruction of 'C0' for a particular host as meaning 
> 'no connections', whereas the documentation states that this should allow 
> unlimited connections up to the global limit. This situation only arises 
> when there is a global per-host concurrency limit which is being overridden 
> for particular IPs. Patch below.

Yes, thanks a lot for pointing this out.  See below for a slightly
updated patch; if per host concurrency isn't enabled globally,
concurrency instructions must be ignored.

Regards, Gerrit.

PS: You're on the wrong list.
diff (text/plain, 444 B)
Index: src/tcpsvd.c
===================================================================
RCS file: /var/lib/cvs/ipsvd/src/tcpsvd.c,v
retrieving revision 1.21
diff -u -r1.21 tcpsvd.c
--- src/tcpsvd.c	13 Feb 2004 13:19:01 -0000	1.21
+++ src/tcpsvd.c	7 Jul 2004 11:16:09 -0000
@@ -172,7 +172,7 @@
   }
   else ac =IPSVD_DEFAULT;
 
-  if (phcc > 0) {
+  if (phcc && phccmax) {
     if (phcc > phccmax) {
       ac =IPSVD_DENY;
       if (phccmsg) {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.