Re: qconfirm: manual confirmation-only mode?

On Sun, Feb 27, 2005 at 09:44:38PM +0100, clemens fischer wrote:
> Gerrit Pape:
> >  I don't think the 'manual' feature should be a different mode, but
> >  simply an option.  You may want to use it for the message mode and
> >  sender mode.
> 
> sorry for posting late. i already made qconfirm-checks "mode"-variable a
> bitfield, but wanted to test *before posting* this time.
> 
> this patch is two or three days old, i think, it works and provides the
> following benefits:
> 
> adds a `-M' option, which makes qconfirm-check queue emails only.
> confirmations, sneak previews, drops etc. must be done manually.

Ok, but I still think making 'mode' a bit field isn't appropriate, you
cannot have MODE_INODE and MODE_SENDER at the same time, and you can
have the 'manual' option switched in all modes, just like the ack
variable.  Additionally I would prefer to check for the manual mode
where inject_qconfirm_msg() is called, and not in the function itself;
actually sneak previews should be sent using this function too, I think,
and through a .qconfirm/msg/preview template or so.

Another possibility, instead of the -M command line option, could be to
check whether msg/request (and msg/acknowledge, msg/confirm,
msg/preview) exists and is not empty, and refrain from sending the
message if not.

> finally, the qconfirm tests in the distribution could now be enhanced.
> currently qconfirm-check isn't tested aside from checking the version
> string.

Yes, good idea.  Who's going to write a nice qconfirm-check.check now
;-)?

> i'd appreciate this or something like it to be included in the
> distribution.

Please let me know what you think about my comments first.  Thanks for
the contribution.

Regards, Gerrit.