Re: [DEV] Improve locking the screen and shutting down, introduce suspend/hibernate

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

W dniu 26.02.2014 20:09, Ray Satiro pisze:
> Hello Mateusz thank you for your recent changes. I don't know if you and Rob
> have discussed this already and if there is a conversation about the frontend
> let me know. My thinking is why not have the pull down integrated in lock, so if
> you click the caret on the lock button you have some options like sleep
> shutdown, etc.
Yes, it is a good idea.

> Any shutdown should probably have confirmation in case someone clicks it by
> accident or misinterprets it as shutting down the program not shutting down
> their computer (yes users really will think that).
I thought that the pull down menu would be enough to prevent someone from clicking
the button accidentally. As for the user misinterpreting the command, we could make
the description longer: "Shut down the computer", anyway when someone opens the
drop down menu he will see options such as "Restart, hibernate, etc." so it may be
clear what that does.

The "Shutdown..." button opens a menu that has options like "Shutdown, Restart,
Suspend, etc". I was not able to make a screenshot with the menu open and didn't
bother with a camera.

> 
> Before showing the message box you'd have to stop the rest break window from
> being forced on top though and it might be better to close it entirely,
This is not a good idea because that would allow bypassing the rest break window
easily when You have it forced ("Block input" or so).
It may be better to add a second level menu like one has in Gnome2 in the
"Applications" menu: You would then have to select "Shutdown" and then "Confirm" in
the menu.

> I'm not sure how that would play on all platforms. I did that for a client by
> calling on_skip button but the problem with that in this case is it would mess
> statistics.
You mean that closing the window to show the shutdown confirmation would mess
statistics?
What do You mean by calling on_skip button? I can't find the relevant code anywhere.
> If someone shuts down the computer is that skipping a break. I'd argue no.

There is some code in Workrave that detects when the screen is being locked. I
wonder what the purpose of it is. I think that this should not bother Workrave, the
break should go on whether the screen is locked or not.
It would be very good to integrate it into my code because I use the same API.
I wonder whether it should detect suspend/hibernate in a similar fashion.

Currently there is a bug in Workrave: locking the screen in the Daily limit window
and then logging back in would make the window disappear so any "Block input"
settings would be ineffective.

> 
> It's always great to see improvements, thanks again
> 
> 

Where does the 'shutdown.png' icon in Workrave come from? In Git I am only able to
trace it to some commit in 2003 by Raymond Penners. Currently all the sysoper
actions have the same shutdown icon, it does not look good.


> 
> On Wednesday, February 26, 2014 10:41 AM, Mateusz Jończyk <[email protected]>
> wrote: The screenshot mentioned in the pull request discussion.
> 
> -- Pozdrawiam, Mateusz Jończyk AEI, Informatyka, Semestr 2 Magisterskich, BDiIS
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: My public key: 0x2C64C488 on hkp://pool.sks-keyservers.net
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTDkVzAAoJELLT9LcsZMSIls8H/ikz5twTsFr5hnYyfFwldCOc
ARSkEPiMb7JFRE/lvYffobtxqaifQG6Kho246U+6gYOYAvb6C4FLfqfXcl70PbVD
uwHsR3lRrswhiaGb80xMhZrCgqwYs0AauvRCajdRWp6Dys2+4BkP6A3NY9NVUObn
TqC7dWbVQ/QdhPCT++Oth9j+A65hZUKaAg1nlCL+w8rnQJznnKozbLtNn6cLZjh2
p704PtfRHIB3a0vd7VIH2edNm4ldq7u8OlAKCniYDeLobP+J13BtIxv+6+DJy85x
x/2qftWh8h93GWPtqCUi+Gvj8GTSYbRxJY2u/VHgVboTbseFJXhPovSrrVhli+Y=
=MQU4
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Workrave-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/workrave-user