Re: [DEV] Improve locking the screen and shutting down, introduce suspend/hibernate

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,
I have sent this mail over a week ago to workrave-devel. I suspect that nobody
subscribes it, so I'm resending to workrave-user.
- -------------------

W dniu 04.03.2014 00:01, Rob Caelers pisze:
> Hi,
Hello,
> 
>> I am currently working on some fixes to my code that were mentioned by Ray. I 
>> have integrated the Lock option into the dropdown menu and am working on 
>> requiring the user to confirm the operation.
> 
> Great!
> 
I have made some correcitons and placed them into
https://github.com/matjon/workrave-1/tree/improve_lock_and_suspend
The code should now be releasable.
The missing things are:
	- shutdown \ suspend confirmation dialog (I got stuck on it),
	- better icons for suspend/hibernate, now they have the same icon as
          shutdown.

I may rebase it on top of workrave/next if You wish.

>> I have tried making the dropdown menu have the same size as the buttons and 
>> failed to. This is probably a limitation of the theme. So I am sending two 
>> screenshots and am asking which version would You prefer.

I have made better screenshots to allow You (especially Mr Ray Satiro) to better
decide. They reflect the state of branches:
	- improve_lock_and_suspend,
	- make_buttons_height_equal
	- unequal_buttons
respectively.

@Ray:
HButtonBox is unfortunately only for buttons, I don't think I should put the Combobox
there (but this does not fix the difference of heights nonetheless).

So I have a Gtk::Box for all the content at the bottom, which contains the Combobox
and a Gtk::HButtonBox with the break buttons.
In unequal_buttons the HButtonBox is removed.

> But please, don't let this keep you from contributing to the Gtk+ version!
> 
>> When are You going to make a release? I am going to finish my work before.
> 
> Not planned yet. I'm probably going to release 1.10.4 soonish because it has 
> some Linux (unity/gnome) fixes. I can release a 1.10.5 after that with your 
> improvements. So no hurry.
> 
> Kind regards, Rob
> 
> PS: perhaps we should move this discussion to workrave-devel.
> 
Sure, I didn't know about it.


- --
Pozdrawiam,
Mateusz Jończyk
AEI, Informatyka, Semestr 2 Magisterskich, BDiIS
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: My public key: 0x2C64C488 on hkp://pool.sks-keyservers.net
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTJyqtAAoJELLT9LcsZMSIdukH/ime3Fek8g1QWrAB2RFI8Oji
IyckMajj+uUZmdzflJQiT32Lj8A6iObg4IxtxttMOEU84u1mBEwlvRqsQzX1V5Lg
mZIJuaHbBnGWn08GblupMmD1vTTN+YN1CrGqSH3erafHVZtC137xIeWlfIwDxzJl
qYQGSGuhYz8doEpPpLlKyotWD95T2wua5NQ0JIGmEXraQxA+KELWAKIsfB7+jzfw
PdTKNpkr9XW1kD0lHyAcYuuIh+aH2dvofb71QumoABb+2mpRsGlcCtfNUHawiTVs
A2wun+U+t3hZ7OURMQnrhzbB3foyZfnBHM4EQnnDbOVp7TtD3ddN5DViW/ATavs=
=OkVI
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

_______________________________________________
Workrave-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/workrave-user