Re: [bitpim-cvs-checkins] bitpim com_samsungscha650.py,1.30,1.31 com_samsungscha670.py,1.26,1.27 conversions.py,1.14,1.15 fileinfo.py,1.8,1.9 ringers.py,1.22,1.23

Joe,

Is there any particular reason you screwed this file up?

> Index: conversions.py
>     ret=os.spawnl( *( (os.P_WAIT, args[0])+args)) # looks like C code ...
>     if ret!=0:
> -        raise common.CommandExecutionFailed(ret, args)
> +        raise common.CommandExecutionFailed(retcode, args)

That should be ret, like it was.

> -        try: os.remove(shortfilename(wavfile))
> -        except OSError: pass
>         run(ffmpeg, "-i", shortfilename(inputfilename), shortfilename(wavfile))
> -        try: os.remove(shortfilename(mp3file))
> -        except OSError: pass

Those lines need to be there because ffmpeg gets upset on Linux and probably 
Mac if the output file already exists.


The identification of wav is nice.

Roger


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt